New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If workspace base image does not have labels, skip merge of image labels #7252
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
@osallou you'll need to sign ECA before being able to accept a PR |
ci-build |
I just signed the ECA, but does not seem to be taken into account in checks... |
Relates to eclipse-che#7249 If image does not have labels in config, the merge fails with nullpointerexception. This patch does the merge only if labels!=null Signed-off-by: Olivier Sallou <olivier.sallou@gmail.com>
Build # 4317 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4317/ to view the results. |
Signed-off-by: Olivier Sallou <olivier.sallou@gmail.com>
ci-build |
Build # 4318 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4318/ to view the results. |
@osallou could you please run command
in traefik module to fix the formatting issue, thanks also if you can add a test in https://github.com/osallou/che/blob/231cd2d44b20d3321b9d13ac9f17cd5aade1cdd7/plugins/plugin-traefik/plugin-traefik-docker/src/test/java/org/eclipse/che/plugin/traefik/TraefikCreateContainerInterceptorTest.java with when(imageInfoConfig.getLabels()).thenReturn(null); |
Signed-off-by: Olivier Sallou <olivier.sallou@gmail.com>
ci-build |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4319/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @osallou !
What does this PR do?
This PR fixes issue #7249. If image does not have labels in config, the merge fails with nullpointerexception. This patch does the merge only if labels!=null
What issues does this PR fix or reference?
With SINGLE_MODE, if image does not have any LABEL, an exception is raised when trying to merge the labels. This PR checks that LABEL is not null before merge, else skip the merge.
Release Notes
N/A
Docs PR
None, bug fix only. No impact on documentation.