Introduce wsagent ping success threshold #7766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0rd
added
kind/enhancement
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
|
Can one of the admins verify this patch? |
l0rd
force-pushed
the
wsagent-ping-success-threshold
branch
from
f7f05ee
to
b70ddb6
Compare
ibuziuk
approved these changes
Dec 7, 2017
davidfestal
approved these changes
Dec 7, 2017
tolusha
approved these changes
Dec 7, 2017
|
ci-build |
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
l0rd
force-pushed
the
wsagent-ping-success-threshold
branch
from
b70ddb6
to
b95c062
Compare
slemeur
approved these changes
Dec 7, 2017
|
Build # 4374 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4374/ to view the results. |
|
ci-build |
riuvshin
approved these changes
Dec 7, 2017
skabashnyuk
approved these changes
Dec 7, 2017
|
Build # 4375 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4375/ to view the results. |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It introduces a ping success threshold in the wsagent launcher. That's the minimum consecutive successes for the ping to be considered successful after having failed. Defaults to 1.
What issues does this PR fix or reference?
This is needed for situations where one successful ping is not enough to consider that the wsagent is started: openshiftio/openshift.io#1304 (comment)