Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: Add the 'Assert.fail() to the 'CommitFilesTest' related to known issue #8047

Merged
merged 2 commits into from
Dec 26, 2017

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Add the 'Assert.fail() to the selenium test 'CommitFilesTest' related to known issue
  • Add the deletion of commit form in the test 'CommitFilesTest'
  • Add the 'isWidgetOpen' method in the page objects 'GitCommit' and 'Git'
  • Correct the name of method 'clickOnCancelBtnComitForm' in the page object 'Git'

What issues does this PR fix or reference?

#8043
#8042

Add the 'Assert.fail() to the selenium test 'CommitFilesTest' related to known issue
Add the deletion of commit form in the test 'CommitFilesTest'
Add the 'isWidgetOpen' method in the page objects 'GitCommit' and 'Git'
Correct the name of method in the page object 'Git'
@artaleks9 artaleks9 added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/production labels Dec 26, 2017
/**
* check open state of commit form
*
* @return true if widget is open
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open > opened

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it is corrected.

@artaleks9 artaleks9 merged commit 150f0a1 into master Dec 26, 2017
@artaleks9 artaleks9 deleted the add-assert-fail branch December 26, 2017 14:25
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 26, 2017
@benoitf benoitf added this to the 6.0.0-M4 milestone Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants