Add an ability to set INFRA_OPENSHIFT_[USERNAME|PASSWORD|TOKEN] to empty #8129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
kind/enhancement
|
@JamesDrummond I missed that you'd already done these changes in your new PR. |
riuvshin
approved these changes
Jan 3, 2018
|
I would prefer this smaller PR |
|
Yes use this one. I changed mine to be like yours so should not be any merge conflicts on my end. |
JamesDrummond
pushed a commit
that referenced
this pull request
Jan 3, 2018
Signed-off-by: James Drummond james@devcomb.com
JamesDrummond
approved these changes
Jan 3, 2018
ghost
approved these changes
Jan 3, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now there is no an ability to set infra OpenShift
USERNAME,PASSWORDorTOKENto empty because of ternary operator in bash uses the default value in this case. See #7893 (comment)So these changes add an ability to set INFRA_OPENSHIFT_[
USERNAME|PASSWORD|TOKEN] to empty.What issues does this PR fix or reference?