Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port retrieving for probes on OpenShift #8194

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

garagatyi
Copy link

What does this PR do?

Fix port retrieving for probes on OpenShift. Because of usage of URI and URL which return -1 as a port when the port is not specified in the URL.

What issues does this PR fix or reference?

Related to #7550

Release Notes

Docs PR

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/platform labels Jan 5, 2018
@garagatyi garagatyi merged commit 0e1e39f into eclipse-che:master Jan 5, 2018
@garagatyi garagatyi deleted the fixProbesOpenShift branch January 5, 2018 12:17
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 5, 2018
@benoitf benoitf added this to the 6.0.0-M5 milestone Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants