Openshift ocp fails due to livenessProbe. #8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The livenessProbe's failureThreshold is set to low. This causes the livenessProbe having to short a period of probing before it fails and removes the container. The failureThreshold is set to 4, the initialDelaySeconds is set to 5 and the periodSeconds is 5. This means 5s+4x5s=25s before the container fails. This patch set failureThreshold higher to 11 allowing for a more reasonable overall probe time of 60s (5s+11x5s=60s) before fails and removes the container. Signed-off-by: James Drummond <james@devcomb.com>
JamesDrummond
added
kind/bug
JamesDrummond
requested review from
benoitf,
riuvshin,
a user and
sleshchenko
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Put high severity as keycloak on multiuser will fail unless using a pod with high CPU that can startup keycloak under 25 seconds. |
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
riuvshin
approved these changes
Jan 15, 2018
benoitf
approved these changes
Jan 15, 2018
ghost
approved these changes
Jan 15, 2018
benoitf
removed
the
status/code-review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The livenessProbe's failureThreshold is set to low. This causes the livenessProbe having to short a period of probing before it fails and removes the container. The failureThreshold is set to 4, the initialDelaySeconds is set to 5 and the periodSeconds is 5. This means 5s+4x5s=25s before the container fails. This patch set failureThreshold higher to 11 allowing for a more reasonable overall probe time of 60s (5s+11x5s=60s) before fails and removes the container.
What issues does this PR fix or reference?
#7799
Release Notes
N/A
Signed-off-by: James Drummond james@devcomb.com