Refactored Window class #8374

vzhukovs · 2018-01-19T14:01:31Z

What does this PR do?

Clean up the interface of Window class;
Move GWT specific functionality to bridge (CompositeWindowView) which is responsible only for construct window object on the view;
Better handling key press events on the windows;
Adopted Window implementations to use new interface of Window class;
Move utility methods such as detecting whether widget is in focus to DomUtils utility class.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

Release Notes

Docs PR

- Clean up the interface of Window class; - Move GWT specific functionality to bridge (CompositeWindowView) which is responsible only for construct window object on the view; - Better handling key press events on the windows; - Adopted Window implementations to use new interface of Window class; - Move utility methods such as detecting whether widget is in focus to DomUtils utility class. Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> # Conflicts: # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/factory/json/ImportFromConfigViewImpl.java # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/resources/selector/SelectPathViewImpl.java # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/upload/file/UploadFileViewImpl.java # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/upload/folder/UploadFolderFromZipViewImpl.java # ide/che-core-ide-ui/src/main/resources/org/eclipse/che/ide/ui/window/CompositeWindowView.css # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/checkout/CheckoutReferenceViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/compare/CompareViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/fetch/FetchViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/history/HistoryViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/merge/MergeViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/pull/PullViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/push/PushToRemoteViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/remote/RemoteViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/reset/commit/ResetToCommitViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/reset/files/ResetFilesViewImpl.java # plugins/plugin-git/che-plugin-git-ext-git/src/main/java/org/eclipse/che/ide/ext/git/client/revert/RevertCommitViewImpl.java # plugins/plugin-help/che-plugin-help-ext-client/src/main/java/org/eclipse/che/ide/ext/help/client/about/AboutViewImpl.java

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs · 2018-02-06T16:41:49Z

ci-test

codenvy-ci · 2018-02-06T21:56:35Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8374
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> # Conflicts: # plugins/plugin-java/che-plugin-java-ext-lang-client/src/main/java/org/eclipse/che/ide/ext/java/client/navigation/filestructure/FileStructurePresenter.java

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs · 2018-02-07T13:44:48Z

ci-build

codenvy-ci · 2018-02-07T14:21:08Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4462/

vparfonov · 2018-02-07T15:40:46Z

...che-core-ide-app/src/main/java/org/eclipse/che/ide/command/editor/CommandEditorViewImpl.java

@@ -36,7 +35,7 @@

  private static final CommandEditorViewImplUiBinder UI_BINDER =
      GWT.create(CommandEditorViewImplUiBinder.class);
-  private static final Window.Resources WINDOW_RESOURCES = GWT.create(Window.Resources.class);
+  //  private static final Window.Resources WINDOW_RESOURCES = GWT.create(Window.Resources.class);


commented code

vparfonov · 2018-02-07T15:46:22Z

...-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/dialogs/confirm/ConfirmDialogViewImpl.java

@@ -53,7 +56,7 @@ public void setDelegate(final ActionDelegate delegate) {
  }

  @Override
-  protected void onEnterClicked() {
+  public void onEndPress(NativeEvent evt) {


wrong method name

vparfonov · 2018-02-07T15:47:26Z

ide/che-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/window/CompositeWindowView.java

+import com.google.gwt.dom.client.Document;
+import com.google.gwt.dom.client.Element;
+import com.google.gwt.dom.client.Style;
+import com.google.gwt.event.dom.client.*;


vparfonov · 2018-02-07T15:55:05Z

ide/che-core-ide-ui/src/main/resources/org/eclipse/che/ide/ui/window/CompositeWindowView.css

-    width: 56px;
-    height: 56px;
-}
+}


Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs · 2018-02-12T10:22:32Z

ci-build

codenvy-ci · 2018-02-12T10:53:27Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4467/

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs requested review from dkuleshov, evidolob, tolusha and vparfonov as code owners January 19, 2018 14:01

vzhukovs removed request for evidolob, dkuleshov, vparfonov and tolusha January 19, 2018 14:01

benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 19, 2018

Fix formatting issue

332e0d1

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 19, 2018

eclipse-che deleted a comment from codenvy-ci Jan 19, 2018

benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 19, 2018

vzhukovs added 3 commits January 19, 2018 17:03

Fix errors

627abfb

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

eclipse-che deleted a comment from codenvy-ci Jan 22, 2018

vzhukovs added 4 commits January 22, 2018 15:10

Code improvements

4d9b7d7

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Rename variable

469304b

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Fixes

e66ebac

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Fix formatting issue

1925e6e

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

eclipse-che deleted a comment from codenvy-ci Jan 23, 2018

Fix formatting issue

9c7610b

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

eclipse-che deleted a comment from codenvy-ci Jan 23, 2018

Minor fixes

d78f1ee

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

eclipse-che deleted a comment from codenvy-ci Jan 23, 2018

Minor fixes

e24e090

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

SkorikSergey approved these changes Feb 7, 2018

View reviewed changes

Merge branch 'master' into che#7200

597fc02

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> # Conflicts: # plugins/plugin-java/che-plugin-java-ext-lang-client/src/main/java/org/eclipse/che/ide/ext/java/client/navigation/filestructure/FileStructurePresenter.java

vzhukovs requested a review from vparfonov February 7, 2018 12:58

vzhukovs added 2 commits February 7, 2018 15:05

Fix test

85ce488

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Fix formatting

2d2bd43

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

eclipse-che deleted a comment from codenvy-ci Feb 7, 2018

vparfonov reviewed Feb 7, 2018

View reviewed changes

vzhukovs added 4 commits February 7, 2018 18:04

Remove commented code

e9ad9d4

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Used corrected method

6341437

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Use single import instead of wildcard

e9a46b9

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

New line

2b27bf7

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

ashumilova removed their request for review February 8, 2018 12:15

Code refinment

4382e0d

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

Fix wildcard imports

2b23c0a

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vparfonov approved these changes Feb 12, 2018

View reviewed changes

svor mentioned this pull request Feb 12, 2018

Make it possible to close Proposals window via Esc #8628

Closed

vzhukovs mentioned this pull request Feb 12, 2018

Update codebase for upcoming changes che-samples/che-plugin-wizard#2

Merged

vzhukovs merged commit ab62845 into master Feb 12, 2018

vzhukovs deleted the che#7200 branch February 12, 2018 13:23

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored Window class #8374

Refactored Window class #8374

vzhukovs commented Jan 19, 2018 •

edited

Loading

vzhukovs commented Feb 6, 2018

codenvy-ci commented Feb 6, 2018

vzhukovs commented Feb 7, 2018

codenvy-ci commented Feb 7, 2018

vparfonov Feb 7, 2018

vzhukovs Feb 7, 2018

vparfonov Feb 7, 2018

vzhukovs Feb 7, 2018

vparfonov Feb 7, 2018

vzhukovs Feb 7, 2018

vparfonov Feb 7, 2018

vzhukovs Feb 7, 2018

vzhukovs commented Feb 12, 2018

codenvy-ci commented Feb 12, 2018

Refactored Window class #8374

Refactored Window class #8374

Conversation

vzhukovs commented Jan 19, 2018 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

vzhukovs commented Feb 6, 2018

codenvy-ci commented Feb 6, 2018

vzhukovs commented Feb 7, 2018

codenvy-ci commented Feb 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vzhukovs commented Feb 12, 2018

codenvy-ci commented Feb 12, 2018

vzhukovs commented Jan 19, 2018 •

edited

Loading