Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stopping test workspace #8427

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Remove stopping test workspace #8427

merged 1 commit into from
Jan 24, 2018

Conversation

dmytro-ndp
Copy link
Contributor

What does this PR do?

It fixes TestWorkspaceServiceClient::delete() method to make it possible to remove stopping test workspace, to avoid an error like the following:

[ERROR] tearDown(org.eclipse.che.selenium.dashboard.WorkspacesListTest)  Time elapsed: 21.535 s  <<< FAILURE!
org.eclipse.che.api.core.ConflictException: Could not stop the workspace 'che/wksp-mil0n' because its status is 'STOPPING'.
	at org.eclipse.che.selenium.dashboard.WorkspacesListTest.tearDown(WorkspacesListTest.java:68)

Remove stopping test workspace
d18c8e7 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@dmytro-ndp dmytro-ndp added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/production labels Jan 24, 2018
@dmytro-ndp dmytro-ndp merged commit 9d98828 into master Jan 24, 2018
@dmytro-ndp dmytro-ndp deleted the fix-test-workspace-removal branch January 24, 2018 09:07
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 24, 2018
@benoitf benoitf added this to the 6.0.0-M5 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.0.0-M5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmytro-ndp @tolusha @benoitf