Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to generate ssh key at import private repo from github #8564

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Feb 1, 2018

What does this PR do?

Change behavior at importing repo from github.

Current behavior:
We try to import repo by ssh regardless if user has ssh key

New behavior:
We check if user has ssh key when user click 'Load repo' button:

Ssh key is available -> we import repo by ssh regardless if repo public or private

Ssh key is not available and repo is public -> we import repo by http

Ssh key is not available and repo is private ->

  • We display prompt to generate ssh key
  • We generate ssh key and import repo by ssh when user accept this operation
  • We remember user's rejection to generate key to don't disturb user anymore and do not display the dialog again when user click on a private repo
  • We set http url (not ssh url) in corresponding field when user reject key generation

What issues does this PR fix or reference?

#6765

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 1, 2018
@RomanNikitenko
Copy link
Member Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8564
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Copy link
Contributor

@artaleks9 artaleks9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test report is OK

@RomanNikitenko RomanNikitenko merged commit 4e6e8b3 into master Feb 5, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-6765 branch February 5, 2018 12:15
@RomanNikitenko RomanNikitenko added this to the 6.1.0 milestone Feb 5, 2018
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants