Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia stacks from Florent's theia prototype #8600

Merged
merged 6 commits into from Feb 5, 2018
Merged

Theia stacks from Florent's theia prototype #8600

merged 6 commits into from Feb 5, 2018

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Adding two stacks. One for docker other for Openshift.

  1. Both stacks have two machines. One with theiaide/theia other is base eclipse/che-dev:nightly.
  2. theia configred to start from /projects volume
  3. theia has 3030 port exposed, dev - 3000

What issues does this PR fix or reference?

#8267

Release Notes

n/a

Docs PR

n/a

@skabashnyuk skabashnyuk requested review from benoitf and a user February 5, 2018 07:42
@skabashnyuk skabashnyuk changed the title Theia stacks from Florent's prototype Theia stacks from Florent's theia prototype Feb 5, 2018
"id": "java-theia-docker",
"creator": "ide",
"name": "Java Theia (docker)",
"description": "Java + Theia in a sidecar container (docker)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could replace "Java" by "che dev" image or "Che development"

"commands": []
},
"stackIcon": {
"name": "type-java.svg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we replace the logo by something more theia ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked but they have nothing to share.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could do like for C++ with a generic "text" logo waiting the official logo in svg format.
Because in the che dev machine we have other tools than java.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ashumilova ashumilova added this to the 6.1.0 milestone Feb 5, 2018
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Feb 5, 2018
@skabashnyuk skabashnyuk merged commit cc8b22e into master Feb 5, 2018
@skabashnyuk skabashnyuk deleted the theiastack branch February 5, 2018 11:55
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants