-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Apache Camel LSP support #8648
Conversation
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Change-Id: I936fc1ce11766f6490ceaaefe7d3b0757f6c0301 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Build # 4454 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4454/ to view the results. |
jenkins ci test failure seems to be not related |
Build # 4455 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4455/ to view the results. |
@riuvshin it seems jenkins slave node is quite unstable |
I do not see any issue with slave, in both build we had failed tests... maybe tests are not much stable, but anyways I will check ci slave |
ci-build |
|
||
touch ${LS_LAUNCHER} | ||
chmod +x ${LS_LAUNCHER} | ||
echo "java -jar ${LS_DIR}/camel-lsp-server.jar" > ${LS_LAUNCHER} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does all images contain java?
Should we check and echo some message if so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha AFAIK yes for ws-agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and without ws-agent the LS is useless
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4456/ |
What does this PR do?
It brings Apache Camel LSP on top of XML files that are using Apache Camel namespace
![camel-lsp](https://user-images.githubusercontent.com/436777/35907887-73d4e40c-0bef-11e8-86a1-f265528c20ef.gif)
LSP server is using Apache 2 License
https://github.com/lhein/camel-language-server/blob/master/LICENSE
What issues does this PR fix or reference?
openshiftio/openshift.io#2024
Release Notes
Add Apache Camel LSP to existing LSP list