Catch issue #8468 in the ProjectExplorer page-object #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohrimenko1988
added
kind/bug
dmytro-ndp
approved these changes
Feb 8, 2018
| } catch (TimeoutException ex) { | ||
| return false; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I have not quiet understood why we need SeleniumWebDriverHelper, why not SeleniumWebDriverUtils class? The classes very similar as for me.
There was a problem hiding this comment.
SeleniumWebDriverUtils - means utility to expand SeleniumWebDriver functionality itself, while SeleniumWebDriverHelper provides high-level functionality which just consume SeleniumWebDriver
musienko-maxim
approved these changes
Feb 8, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Catch issue #8468 in the ProjectExplorer page-object
What issues does this PR fix or reference?
Issue: #8468
Release Notes
Docs PR