Support Compose memory limit byte units #8837
Conversation
mkuznyetsov
added
the
kind/bug
| import com.fasterxml.jackson.databind.JsonDeserializer; | ||
| import java.io.IOException; | ||
| import org.eclipse.che.commons.lang.Size; | ||
|
|
|
ci-test |
|
ci-test build report: |
| try { | ||
| return Size.parseSize((String) memLimit); | ||
| } catch (IllegalArgumentException e) { | ||
| throw ctxt.mappingException(format(UNSUPPORTED_VALUE_MESSAGE, memLimit)); |
There was a problem hiding this comment.
You can ignore this exception since the following operation throws the same exception
|
|
||
| private ComposeEnvironmentFactory factory; | ||
|
|
||
| private static final String RECIPE_WITHOUT_COMMAND_VALUE = |
There was a problem hiding this comment.
This test is not related to a command. Looks like the name is a copy-paste error. BTW can we remove everything not related to these tests from the recipe to make class clearer?
| @Test(dataProvider = "validValues") | ||
| public void shouldDeserializeValues(Object memoryLimit, Object parsedLimit) | ||
| throws ValidationException { | ||
| ComposeRecipe service = |
There was a problem hiding this comment.
Name of var is misleading - it is a recipe that may contain a number of services.
| public Object[][] validValues() { | ||
| return new Object[][] { | ||
| {"2048", 2048L}, | ||
| {"1gb", 1073741824L}, |
There was a problem hiding this comment.
Can you replace these magic constants with something evaluated from constants?
E.g.
private static final long K = 1024;
...
private static final long G = 1024 * M;
{"1gb", 1 * G},
What does this PR do?
Allow using byte units for defining memory limit in Compose configuration (numbers followed my "b, kb", etc.)
What issues does this PR fix or reference?
#8232