Allow configuring the dispatcher and connection pool of the KubernetesClient shared underlying http client.
#8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... of the `KubernetesClient` shared underlying http client. For example, default values are 64 concurrent asynchronous requests, and **only 5 concurrent asynchronous requests per-host**, which obviously doesn't seem correct for multi-user scenarios, knowing that Che keeps a number of connections opened (e.g. for commands or ws-agent logs) Leaving these wrong default values can lead to workspace starts being stuck in the middle of the process while waiting for an available request, as soon as several users start a workspace on the same che-server. Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
requested review from
garagatyi,
riuvshin and
skabashnyuk
as code owners
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
|
ci-test-ocp |
|
ci-test build report: |
|
Maybe we should move |
Why not in a next PR ;-) |
ibuziuk
approved these changes
Feb 26, 2018
l0rd
approved these changes
Feb 26, 2018
garagatyi
approved these changes
Feb 26, 2018
| # Keep-alive timeout of the connection pool | ||
| # of the Kubernetes-client shared http client | ||
| # in minutes | ||
| che.infra.kubernetes.client.http.connection_pool.keep_alive.mins=5 |
There was a problem hiding this comment.
We practice separation of measurement unit by underscore instead of a dot
There was a problem hiding this comment.
Fixed in commit e88a264
akorneta
approved these changes
Feb 26, 2018
sleshchenko
approved these changes
Feb 26, 2018
... as requested by @garagatyi in [this comment](#8892 (comment)) Signed-off-by: David Festal <dfestal@redhat.com>
l0rd
approved these changes
Feb 26, 2018
benoitf
removed
the
status/code-review
riuvshin
pushed a commit
that referenced
this pull request
Feb 26, 2018
…esClient` shared underlying http client. (#8892) Allow configuring the dispatcher and connection pool of the `KubernetesClient` shared underlying http client. For example, default values are 64 concurrent asynchronous requests, and **only 5 concurrent asynchronous requests per-host**, which obviously doesn't seem correct for multi-user scenarios, knowing that Che keeps a number of connections opened (e.g. for commands or ws-agent logs) Leaving these wrong default values can lead to workspace starts being stuck in the middle of the process while waiting for an available request, as soon as several users start a workspace on the same che-server. Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow configuring the dispatcher and connection pool of
the
KubernetesClientshared underlying http client.For example, default values are 64 concurrent asynchronous
requests, and only 5 concurrent asynchronous requests per-host,
which obviously doesn't seem correct for multi-user scenarios,
knowing that Che keeps a number of connections opened
(e.g. for commands or ws-agent logs)
Leaving these wrong default values can lead to workspace
starts being stuck in the middle of the process while waiting
for an available request, as soon as several users start
a workspace on the same che-server.