Move deployment files out of dockerfiles folder #9143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move openshift/k8s deployment files from dockerfiles/init folder to deploy folder with a better structure because they are not related to init dockerfile. Add readme files in each deployment target folder with links to Che docs where the process of deployment is described. Remove delivery of deployment files by init image which is useless. Remove empty docs files from the repo and init image. Fix some minor typos and trailing spaces. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
garagatyi
requested review from
l0rd and
a user
and removed request for
vparfonov
benoitf
added
the
status/code-review
|
@eivantsov we need to collaborate to adapt Che docs to the changes in this PR. |
|
should we also move some other docker images (cli) from |
|
@benoitf yes, we could move it. But other parts are more tightly integrated with the CLI and puppet. I'm not sure it is what I should focus on right now. So will leave this task for other PRs with improvements. |
|
@riuvshin we will need to collaborate to adapt CI to the changes in this PR. |
|
@garagatyi yes it could be a 'part 2' |
benoitf
approved these changes
Mar 20, 2018
ghost
approved these changes
Mar 20, 2018
l0rd
approved these changes
Mar 20, 2018
benoitf
removed
the
status/code-review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move openshift/k8s deployment files from dockerfiles/init folder
to deploy folder with a better structure because they are not
related to init dockerfile.
Add readme files in each deployment target folder with links to
Che docs where the process of deployment is described.
Remove delivery of deployment files by init image which is
useless.
Remove empty docs files from the repo and init image.
Fix some minor typos and trailing spaces.
Tested on next deployments:
What issues does this PR fix or reference?
Related to redhat-developer/rh-che#528, #8822, #8982
Release Notes
Docs PR