Selenium: cover sharing workspaces in organization by selenium test #9167

SkorikSergey · 2018-03-21T12:21:57Z

What does this PR do?

This PR create ShareWorkspaceTest selenium test which cover sharing workspaces with members of an organization.

What issues does this PR fix or reference?

…kspacesInOrganization

olexii4 · 2018-03-21T12:35:46Z

dashboard/src/app/workspaces/share-workspace/user-item/user-item.html

@@ -19,16 +20,16 @@
           class="che-list-item-name">
        <span class="che-xs-header noselect" hide-gt-xs>Email</span>
        <span><img class="user-face" gravatar-src="userItemController.user.email"></span>
-        <span class="user-email che-hover ">{{userItemController.user.email}}</span>
+        <span class="user-email che-hover " name="member-name">{{userItemController.user.email}}</span>


Could you rename "member-name" to "member-email"

Also I would notice that it is about user, not member.

name attribute is usually used in input elements. It's better to use id for div element.

dmytro-ndp · 2018-03-21T13:45:39Z

dashboard/src/app/workspaces/share-workspace/user-item/user-item.html

@@ -1,5 +1,6 @@
 <che-list-item flex-gt-sm="100" flex="33" ng-mouseover="hover=true" ng-mouseout="hover=false">
  <div flex="100"
+       id="member-name-{{userItemController.user.email}}"


It's about user email, not member name.

dmytro-ndp · 2018-03-21T13:46:45Z

dashboard/src/app/workspaces/share-workspace/user-item/user-item.html

      </div>
      <div flex-gt-xs="35">
        <span class="che-xs-header noselect" hide-gt-xs>Permissions</span>
-        <span class="user-permissions">{{userItemController.getUserActions()}}</span>
+        <span class="user-permissions" name="member-permissions">{{userItemController.getUserActions()}}</span>


It seems is about user, not member.

name attribute is usually used in input elements. It's better to use id for div element.

Each member has permissions and id is not suitable here.

dmytro-ndp · 2018-03-21T14:09:25Z

dashboard/src/app/workspaces/share-workspace/user-item/user-item.html

      </div>
      <div flex-gt-xs="25">
        <span class="che-xs-header noselect" hide-gt-xs>Actions</span>
                  <span class="che-list-actions">
-                    <div ng-click="userItemController.removeUser();" uib-tooltip="Remove member">
+                    <div ng-click="userItemController.removeUser();" uib-tooltip="Remove member" name="remove-member">


name attribute is usually used in input elements. It's better to use id for div element.

dmytro-ndp · 2018-03-21T14:12:32Z

...m-test/src/test/java/org/eclipse/che/selenium/dashboard/organization/ShareWorkspaceTest.java

+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+@Test(groups = {TestGroup.MULTIUSER})


You can omit {} brackets here for single group: Test(groups = TestGroup.MULTIUSER)

dmytro-ndp · 2018-03-21T14:14:40Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

 import org.openqa.selenium.support.PageFactory;
-import org.openqa.selenium.support.ui.WebDriverWait;

 public class WorkspaceShare {
  private final SeleniumWebDriver seleniumWebDriver;


We don't need separate field seleniumWebDriver while we use seleniumWebDriverHelper only.

dmytro-ndp · 2018-03-21T14:15:24Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java


  @Inject
-  public WorkspaceShare(SeleniumWebDriver seleniumWebDriver) {
+  public WorkspaceShare(
+      SeleniumWebDriver seleniumWebDriver, SeleniumWebDriverHelper seleniumWebDriverHelper) {
    this.seleniumWebDriver = seleniumWebDriver;


this.seleniumWebDriver bacame redundant here

dmytro-ndp · 2018-03-21T14:16:59Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

+    seleniumWebDriverHelper.waitAndClick(bulkSelection);
+  }
+
+  public void typeToSearchInput(String value) {


Looks like it is filterMembers method

dmytro-ndp · 2018-03-21T14:17:19Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

+  }
+
+  @FindBy(xpath = Locators.FILTER_MEMBERS_BY_NAME_FIELD_XPATH)
+  WebElement filterMembers;


memberFilter ?

or filterMembersField?

dmytro-ndp · 2018-03-21T14:20:46Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

-    new WebDriverWait(seleniumWebDriver, REDRAW_UI_ELEMENTS_TIMEOUT_SEC)
-        .until(
-            invisibilityOfElementLocated(By.xpath(format(Locators.DEVELOPER_SHARE_ITEM, email))));
+    String ADD_DEVELOPER_BTN_XPATH = "//che-button-primary[@che-button-title='Add Developer']";


We don't need to shorten BUTTON to BTN, because it doesn't effectively shorten the code, but make it harder to understand.

dmytro-ndp · 2018-03-21T14:22:17Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

+    String ADD_DEVELOPER_BTN_XPATH = "//che-button-primary[@che-button-title='Add Developer']";
+    String BULK_SELECTION_ID = "share-workspace-bulk-selection";
+    String FILTER_MEMBERS_BY_NAME_FIELD_XPATH = "//input[@ng-placeholder='Search']";
+    String MEMBER_ITEM_XPATH = "//div[@id='member-name-%s']";


MEMBER_ITEM_XPATH is actually MEMBER_ITEM_XPATH_PATTERN which should be completed before usage.

dmytro-ndp · 2018-03-21T14:34:04Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

+  @FindBy(id = Locators.BULK_SELECTION_ID)
+  WebElement bulkSelection;
+
+  public void clickOnBulk() {


clickOnBulkSelection?

dmytro-ndp · 2018-03-21T14:38:47Z

...m-test/src/test/java/org/eclipse/che/selenium/dashboard/organization/ShareWorkspaceTest.java

+    assertEquals(workspaceShare.getMemberPermissions(systemAdminName), ADMIN_PERMISSIONS);
+
+    // check selecting member by checkbox
+    workspaceShare.clickOnMemberCheckbox(systemAdminName);


Looks like a separate test checkSelectingMemberByCheckbox, IMHO
I would prefer specialized tests to generalized ones.

dmytro-ndp · 2018-03-21T14:39:06Z

...m-test/src/test/java/org/eclipse/che/selenium/dashboard/organization/ShareWorkspaceTest.java

+    assertFalse(workspaceShare.isMemberCheckedInList(systemAdminName));
+
+    // check selecting members by Bulk
+    workspaceShare.clickOnBulk();


Looks like a separate test checkMembersBulkSelection, IMHO

dmytro-ndp · 2018-03-21T16:08:35Z

...t/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceShare.java

+    String BULK_SELECTION_ID = "share-workspace-bulk-selection";
+    String FILTER_MEMBERS_BY_NAME_FIELD_XPATH = "//input[@ng-placeholder='Search']";
+    String MEMBER_ITEM_XPATH = "//div[@id='member-name-%s']";
+    String MEMBER_NAME_XPATH = MEMBER_ITEM_XPATH + "//span[@name='member-name']";


It is also looks like xpath pattern

SkorikSergey · 2018-03-22T13:20:40Z

ci-test

codenvy-ci · 2018-03-22T14:07:51Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9167
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey · 2018-03-22T15:48:33Z

ci-test

…kspacesInOrganization

codenvy-ci · 2018-03-23T01:53:33Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9167
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…9167)

SkorikSergey added 8 commits March 16, 2018 12:16

created ShareWorkspaceTest

6e6a088

added locators for the Share tab

73a7c09

added method for working with members

6594563

added method for filtering members in Share list, format

b5d0159

chaged permissions for added member

4a2a885

Merge branch 'master' of https://github.com/eclipse/che into shareWor…

43e9f72

…kspacesInOrganization

ShareWorkspacesTest test renamed to ShareWorkspaceTest

2f6d65c

ShareWorkspaceTest added to CheOneThreadTestsSuite.xml test suite

9ad113c

SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Mar 21, 2018

SkorikSergey requested review from dmytro-ndp and olexii4 March 21, 2018 12:21

SkorikSergey requested review from ashumilova, benoitf and vparfonov as code owners March 21, 2018 12:21

olexii4 approved these changes Mar 21, 2018

View reviewed changes

dmytro-ndp reviewed Mar 21, 2018

View reviewed changes

SkorikSergey added 3 commits March 22, 2018 10:59

changed locators, methods names, comments

ee43372

changed locators for member items in the Share workspace list

e24379f

ShareWorkspaceTest added to multiuser test group

8925e93

dmytro-ndp approved these changes Mar 22, 2018

View reviewed changes

Merge branch 'master' of https://github.com/eclipse/che into shareWor…

66ab29b

…kspacesInOrganization

SkorikSergey merged commit 8c40c87 into master Mar 23, 2018

SkorikSergey deleted the shareWorkspacesInOrganization branch March 23, 2018 07:32

benoitf added this to the 6.3.0 milestone Mar 23, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 23, 2018

skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020

Selenium: cover sharing workspaces in organizations by selenium test (#…

a2bce83

…9167)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium: cover sharing workspaces in organization by selenium test #9167

Selenium: cover sharing workspaces in organization by selenium test #9167

SkorikSergey commented Mar 21, 2018

olexii4 Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

SkorikSergey Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018

SkorikSergey commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

SkorikSergey commented Mar 22, 2018

codenvy-ci commented Mar 23, 2018

Selenium: cover sharing workspaces in organization by selenium test #9167

Selenium: cover sharing workspaces in organization by selenium test #9167

Conversation

SkorikSergey commented Mar 21, 2018

What does this PR do?

What issues does this PR fix or reference?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SkorikSergey commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

SkorikSergey commented Mar 22, 2018

codenvy-ci commented Mar 23, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading