Add the test for checking inactive workspace #9171

musienko-maxim · 2018-03-21T14:50:56Z

What does this PR do?

In CHE 6 has been added functionality for checking activity workspaces. If a user does not produce actions in the Che workspace this one will be stopped according to settings for activity checker.
The test create and launch the test workspace and do delay without any activity, than check that the workspace has been stopped.
@artaleks9, @dmytro-ndp, @SkorikSergey, @Ohrimenko1988. @vparfonov

What issues does this PR fix or reference?

#9166

dmytro-ndp · 2018-03-21T15:00:02Z

Looks like the this PR is about Add the test to check stopping inactive workspace.

musienko-maxim · 2018-03-21T15:08:29Z

ci-build

dmytro-ndp · 2018-03-21T15:10:07Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+            + TOASTLOADER_WIDGET_LATECY_TIMEOUT_IN_MILLISEC;
+    ide.open(testWorkspace);
+    projectExplorer.waitProjectExplorer();
+    WaitUtils.sleepQuietly(commonTimeout, TimeUnit.MILLISECONDS);


Please, explain why we need to sleep here, in comment.

Ohrimenko1988 · 2018-03-21T15:14:31Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+package org.eclipse.che.selenium.workspaces;
+
+import static org.testng.AssertJUnit.assertEquals;
+


Is it exactly what you want to add? Maybe "org.testng.Assert"?

dmytro-ndp · 2018-03-21T15:14:32Z

selenium/che-selenium-test/src/test/resources/conf/selenium.properties

@@ -14,6 +14,8 @@ tests.screenshots_dir=target/screenshots
 tests.htmldumps_dir=target/htmldumps
 tests.workspacelogs_dir=target/workspace-logs
 tests.webdriverlogs_dir=target/webdriver-logs
+che.workspace_agent_dev_inactive_stop_timeout_ms=300000
+active.state_activity_sheduler_period=60000


Could you please rephrase the name of property so that it complies naming convention and describes the proposal clearer?

dmytro-ndp · 2018-03-21T15:15:38Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+
+public class CheckStoppingWsByTimeoutTest {
+
+  private static int TOASTLOADER_WIDGET_LATECY_TIMEOUT_IN_MILLISEC = 20000;


LATECY - what does this mean?

dmytro-ndp · 2018-03-21T15:16:20Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+
+  @Inject
+  @Named("che.workspace_agent_dev_inactive_stop_timeout_ms")
+  private int stoppingTimeotInaciveWorkspace;


Timeot - what does this mean?

Ohrimenko1988 · 2018-03-21T15:22:51Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+    int commonTimeout =
+        stoppingTimeotInaciveWorkspace
+            + shedulerRequstTimeout
+            + TOASTLOADER_WIDGET_LATECY_TIMEOUT_IN_MILLISEC;


What about encapsulate

int commonTimeout = stoppingTimeotInaciveWorkspace shedulerRequstTimeout TOASTLOADER_WIDGET_LATECY_TIMEOUT_IN_MILLISEC;

to the private method, something like "getCommonTimeout()"? This is not necessarily, but in my opinion, it will be more clean:

public void setUp() throws Exception { ide.open(testWorkspace); projectExplorer.waitProjectExplorer(); WaitUtils.sleepQuietly(getCommonTimeout(), TimeUnit.MILLISECONDS); }

And one more remark, typos: "stoppingTimeotInaciveWorkspace" -> "stoppingTimeoutInactiveWorkspace"

Ohrimenko1988 · 2018-03-21T15:29:09Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+  @Inject
+  @Named("active.state_activity_sheduler_period")
+  int shedulerRequstTimeout;
+


dmytro-ndp · 2018-03-21T15:39:34Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+    Workspace workspace =
+        workspaceServiceClient.getByName(
+            testWorkspace.getName(), testUser.getName(), testUser.getAuthToken());
+    assertEquals(workspace.getStatus(), WorkspaceStatus.STOPPED);


Can you, please, explain why we are expecting STOPPED status of workspace here?

codenvy-ci · 2018-03-21T23:24:27Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4496/

dmytro-ndp · 2018-03-22T07:49:57Z

...ium-test/src/test/java/org/eclipse/che/selenium/workspaces/CheckStoppingWsByTimeoutTest.java

+  private int getCommonTimeout() {
+    return cheWorkspaceAgentDevInactiveStopTimeoutMilliseconds
+        + TOASTLOADER_WIDGET_LATENCY_TIMEOUT_IN_MILLISEC
+        + cheWorkspaceActivityCheckSchedulerPeriodInSeconds * 1000;


It's better to point millisecond unit of time measurement in the method name: getCommonTimeoutInMillisec

musienko-maxim · 2018-03-22T08:26:26Z

ci-test

codenvy-ci · 2018-03-22T09:10:26Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9171
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

musienko-maxim · 2018-03-22T12:48:29Z

ci-test-docker-multi

riuvshin · 2018-03-22T12:55:32Z

ci-test

codenvy-ci · 2018-03-22T19:15:10Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9171
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

This reverts commit 8697a5e.

Add the test for checking activity workspaces

c86d215

musienko-maxim requested a review from vparfonov as a code owner March 21, 2018 14:50

musienko-maxim requested review from dmytro-ndp, Ohrimenko1988, SkorikSergey and artaleks9 March 21, 2018 14:51

add new test to testsuite

34af700

artaleks9 approved these changes Mar 21, 2018

View reviewed changes

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Mar 21, 2018

vparfonov approved these changes Mar 21, 2018

View reviewed changes

SkorikSergey approved these changes Mar 21, 2018

View reviewed changes

musienko-maxim changed the title ~~Add the test for checking activity workspaces~~ Add the test for checking inactive workspace Mar 21, 2018

dmytro-ndp reviewed Mar 21, 2018

View reviewed changes

Ohrimenko1988 reviewed Mar 21, 2018

View reviewed changes

dmytro-ndp reviewed Mar 21, 2018

View reviewed changes

Ohrimenko1988 reviewed Mar 21, 2018

View reviewed changes

dmytro-ndp reviewed Mar 21, 2018

View reviewed changes

Maxim Musienko added 2 commits March 21, 2018 18:07

fix typo, incapsulate math operations into method

8c370b2

Fix license, rename the field for better readability

1151b61

dmytro-ndp reviewed Mar 22, 2018

View reviewed changes

Maxim Musienko added 2 commits March 22, 2018 10:07

change of method name for more readability

8de4d3b

apply camel case format

84203a0

musienko-maxim force-pushed the CHE-9166 branch from 49f5a82 to 84203a0 Compare March 22, 2018 08:13

dmytro-ndp approved these changes Mar 22, 2018

View reviewed changes

Ohrimenko1988 approved these changes Mar 22, 2018

View reviewed changes

Roman Iuvshyn and others added 6 commits March 26, 2018 14:27

Merge branch 'master' into CHE-9166

41a6abf

Merge branch 'master' into CHE-9166

cb76b02

Merge branch 'CHE-9166' of github.com:eclipse/che into CHE-9166

de0d4ca

Merge branch 'master' into CHE-9166

96321e0

change method for correct getting the auth. token

d12fddc

remove unused method

1123b5c

dmytro-ndp approved these changes Mar 28, 2018

View reviewed changes

musienko-maxim merged commit 8697a5e into master Mar 28, 2018

musienko-maxim deleted the CHE-9166 branch March 28, 2018 21:49

musienko-maxim restored the CHE-9166 branch March 29, 2018 06:08

musienko-maxim pushed a commit that referenced this pull request Mar 29, 2018

Revert "Add the test for checking inactive workspace (#9171)"

9597384

This reverts commit 8697a5e.

musienko-maxim mentioned this pull request Mar 29, 2018

Revert "Add the test for checking inactive workspace" #9288

Closed

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 29, 2018

benoitf added this to the 6.4.0 milestone Mar 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the test for checking inactive workspace #9171

Add the test for checking inactive workspace #9171

musienko-maxim commented Mar 21, 2018 •

edited

Loading

dmytro-ndp commented Mar 21, 2018

musienko-maxim commented Mar 21, 2018

dmytro-ndp Mar 21, 2018 •

edited

Loading

Ohrimenko1988 Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

dmytro-ndp Mar 21, 2018

Ohrimenko1988 Mar 21, 2018 •

edited

Loading

Ohrimenko1988 Mar 21, 2018 •

edited

Loading

Ohrimenko1988 Mar 21, 2018

dmytro-ndp Mar 21, 2018

codenvy-ci commented Mar 21, 2018

dmytro-ndp Mar 22, 2018 •

edited

Loading

musienko-maxim commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

musienko-maxim commented Mar 22, 2018

riuvshin commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

		package org.eclipse.che.selenium.workspaces;

		import static org.testng.AssertJUnit.assertEquals;


		public class CheckStoppingWsByTimeoutTest {

		private static int TOASTLOADER_WIDGET_LATECY_TIMEOUT_IN_MILLISEC = 20000;

Add the test for checking inactive workspace #9171

Add the test for checking inactive workspace #9171

Conversation

musienko-maxim commented Mar 21, 2018 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

dmytro-ndp commented Mar 21, 2018

musienko-maxim commented Mar 21, 2018

dmytro-ndp Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Ohrimenko1988 Mar 21, 2018

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018

Choose a reason for hiding this comment

Ohrimenko1988 Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Ohrimenko1988 Mar 21, 2018 • edited Loading

Choose a reason for hiding this comment

Ohrimenko1988 Mar 21, 2018

Choose a reason for hiding this comment

dmytro-ndp Mar 21, 2018

Choose a reason for hiding this comment

codenvy-ci commented Mar 21, 2018

dmytro-ndp Mar 22, 2018 • edited Loading

Choose a reason for hiding this comment

musienko-maxim commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

musienko-maxim commented Mar 22, 2018

riuvshin commented Mar 22, 2018

codenvy-ci commented Mar 22, 2018

musienko-maxim commented Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 21, 2018 •

edited

Loading

Ohrimenko1988 Mar 21, 2018 •

edited

Loading

Ohrimenko1988 Mar 21, 2018 •

edited

Loading

dmytro-ndp Mar 22, 2018 •

edited

Loading