Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: wait that Restart button in ToastLoader is clickable #9389

Merged
merged 7 commits into from
Apr 13, 2018
Merged

Selenium: wait that Restart button in ToastLoader is clickable #9389

merged 7 commits into from
Apr 13, 2018

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR:

  • add checking that the Loader is closed before clicking on Restart button in the ToastLoader;;
  • rename CheckRestoringWorkspaceAfterStoppingWsAgentProcess test to CheckRestoringWorkspaceAfterStoppingWsAgentProcessTest;
  • rework ToastLoader and NotificationPopupPanel page objects to work with SeleniumWebDriverHelper;
  • move method for checking buttons in ToastLoader from NotificationPopupPanel to ToastLoader page object.

What issues does this PR fix or reference?

#9388

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/in-progress This issue has been taken by an engineer and is under active development. team/che-qe labels Apr 12, 2018
@SkorikSergey
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9389
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Merge branch 'master' of https://github.com/eclipse/che into fixCheck…
2aafec9 
…RestoringWorkspaceAfterStoppingWsAgentProcessTest
dmytro-ndp
dmytro-ndp reviewed Apr 13, 2018
View reviewed changes
selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ToastLoader.java Outdated
String START_BUTTON = "//button[text()='Start']";
String MAINFORM_WITH_TEXT_CONTAINER =
String MAIN_FORM_ID = "gwt-debug-popupLoader";
String TOAST_LOADER_BUTTON_XPATH = "//div[@id='gwt-debug-popupLoader']//button[text()='%s']";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name it TOAST_LOADER_BUTTON_XPATH_PATTERN to make it obvious that it requires modification before usage.

@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 13, 2018
@SkorikSergey SkorikSergey merged commit 6a6b808 into master Apr 13, 2018
@SkorikSergey SkorikSergey deleted the fixCheckRestoringWorkspaceAfterStoppingWsAgentProcessTest branch April 13, 2018 08:11
@SkorikSergey SkorikSergey removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 13, 2018
@benoitf benoitf added this to the 6.4.0 milestone Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SkorikSergey @codenvy-ci @dmytro-ndp @benoitf