-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-261: Remove UserDao from machine in che. #948
Conversation
@@ -98,7 +91,7 @@ protected void configure() { | |||
@Provides | |||
@SuppressWarnings("unchecked") | |||
Pair<String, String>[] eventSubscriptionsProvider(@Named("event.bus.url") String eventBusURL) { | |||
return new Pair[] {Pair.of(eventBusURL, "")}; | |||
return new Pair[]{Pair.of(eventBusURL, "")}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Other OK for me |
|
||
if (requestURI.contains("/ws") && uriParts.length >= 4) { | ||
environmentContext.setWorkspaceId(uriParts[4]); | ||
if (workspaceId.startsWith("workspace")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think requests to /api/worskpace/user123:workspaceName123 or /api/workspace/name/workspaceName123 will be processed wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the method setWorkspaceIdToContext wants to be removed
ok |
@vparfonov