CHE-253: Refactor Che docker client #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private String repository; | ||
| /** authentication configuration for private registries. Can be null */ | ||
| private AuthConfigs authConfigs; | ||
| /** */ |
| * | ||
| * @author Mykola Morhun | ||
| */ | ||
| public class GetSystemInfoParams { |
There was a problem hiding this comment.
Do we need this new unused empty class?
mmorhun
force-pushed
the
CHE-253
branch
3 times, most recently
from
cddca49
to
1a69c1f
Compare
|
@garagatyi check please |
| @@ -106,12 +107,12 @@ public void setNetworkSettings(NetworkSettings networkSettings) { | |||
| this.networkSettings = networkSettings; | |||
| } | |||
|
|
|||
| public String getResolvConfPath() { | |||
| return resolvConfPath; | |||
| public String getResolveConfPath() { | |||
There was a problem hiding this comment.
It is not a typo. We used the same wording Docker use itself. You can check it by inspecting docker container.
|
@garagatyi I corrected the code according to your comments |
|
|
||
| /** | ||
| * @param container | ||
| * id of container |
There was a problem hiding this comment.
are you sure that only id is valid value?
|
+1 for |
|
+0 |
|
+1 for |
Closed
|
@evoevodin @skabashnyuk check please |
| final DockerResponse response = connection.request(); | ||
| final int status = response.getStatus(); | ||
| if (!(NO_CONTENT.getStatusCode() == status || NOT_MODIFIED.getStatusCode() == status)) { | ||
| if (NO_CONTENT.getStatusCode() != status && NOT_MODIFIED.getStatusCode() != status) { |
There was a problem hiding this comment.
I think that status / 100 != 2 will be better in that case
|
Code looks really good! |
mmorhun
force-pushed
the
CHE-253
branch
7 times, most recently
from
dca4980
to
1a8971f
Compare
|
LGTM |
…without breaking code dependent on docker client Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_2 Upvotes_ Refactor Che docker client to be able to add new parameters without breaking code dependent on docker client