Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Rework the 'RunPlainJavaProjectTest' to use the 'kohsuke Github' library #9602

Merged
merged 9 commits into from
May 7, 2018
Merged

Selenium: Rework the 'RunPlainJavaProjectTest' to use the 'kohsuke Github' library #9602

merged 9 commits into from
May 7, 2018

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Rework the 'RunPlainJavaProjectTest' to use the 'kohsuke Github' library
  • Add the 'run-plain-java-project' to the resources
  • Delete the 'KeepDirectotryGitImportTest' from the 'SmokeTestsSuite' as non already exist
  • Delete the 'PushChangeNotUpdatedRepoTest' from the project as a duplicate of the 'PushingChangesTest'

What issues does this PR fix or reference?

#9458

@artaleks9 artaleks9 requested a review from vparfonov as a code owner May 3, 2018 15:16
@artaleks9
Copy link
Contributor Author

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels May 3, 2018
dmytro-ndp
dmytro-ndp reviewed May 3, 2018
View reviewed changes
...-selenium-test/src/test/java/org/eclipse/che/selenium/plainjava/RunPlainJavaProjectTest.java
codenvyEditor.typeTextIntoEditor(Keys.TAB.toString());
codenvyEditor.typeTextIntoEditor("Mockito mockito = new Mockito();");
codenvyEditor.waitTextIntoEditor("Mockito mockito = new Mockito();");
codenvyEditor.waitMarkerInPosition(ERROR, 9);
codenvyEditor.waitMarkerInPosition(ERROR, 19);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, divide separate steps by empty lines.

dmytro-ndp
dmytro-ndp reviewed May 3, 2018
View reviewed changes
...-selenium-test/src/test/java/org/eclipse/che/selenium/plainjava/RunPlainJavaProjectTest.java Outdated
projectExplorer.openItemByPath(PROJECT_NAME + "/src/com/company/nba/MainClass.java");
codenvyEditor.waitActive();
codenvyEditor.setCursorToLine(12);
codenvyEditor.setCursorToLine(22);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, divide separate steps by empty lines.

dmytro-ndp
dmytro-ndp reviewed May 3, 2018
View reviewed changes
...-selenium-test/src/test/java/org/eclipse/che/selenium/plainjava/RunPlainJavaProjectTest.java
}

private void createNewPackageAndJavaClass() {
projectExplorer.waitAndSelectItem(PROJECT_NAME + "/src");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, divide separate steps by empty lines.

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9602
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9602
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

@artaleks9
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9602
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9 artaleks9 merged commit 0639a2d into master May 7, 2018
@artaleks9 artaleks9 deleted the che#9458 branch May 7, 2018 06:52
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 7, 2018
@benoitf benoitf added this to the 6.5.0 milestone May 7, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
@artaleks9
Selenium: Rework the 'RunPlainJavaProjectTest' to use the 'kohsuke Gi…
526dd63 
…thub' library (eclipse-che#9602)

* Rework the 'RunPlainJavaProjectTest' to use the 'kohsuke Github' library
* Add the 'run-plain-java-project' to the resources
* Delete the 'KeepDirectotryGitImportTest' from the 'SmokeTestsSuite'
* Delete the 'PushChangeNotUpdatedRepoTest' from the project as a duplicate test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@artaleks9 @codenvy-ci @dmytro-ndp @SkorikSergey @benoitf