Rework PlainJava project type and Deprecate SettableValueProvider #9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/context/AppContextImpl.java
…roject' volume defined
…re no 'project' volume defined" This reverts commit 127a79e.
…roject' volume defined
…ode, remove highlighter from the source folder field
|
ci-test |
benoitf
added
the
status/code-review
evidolob
reviewed
May 7, 2018
azatsarynnyy
reviewed
May 7, 2018
| @@ -145,7 +143,7 @@ private void setAttribute(String attrId, List<String> value) { | |||
| } | |||
|
|
|||
| private boolean isCoordinatesCompleted() { | |||
There was a problem hiding this comment.
This method looks redundant since there's just one place where isCoordinatesCompleted() is called.
| delegate.onBrowseSourceButtonClicked(); | ||
| } | ||
| }); | ||
| browseSourceBtn.setVisible(false); |
There was a problem hiding this comment.
browseSourceBtn is always hidden so I guess it's not needed anymore. Should it be removed?
There was a problem hiding this comment.
Agree but lets do it later )
|
ci-test build report: |
|
comments deleted |
azatsarynnyy
approved these changes
May 8, 2018
evidolob
approved these changes
May 8, 2018
vparfonov
approved these changes
May 8, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…lipse-che#9634) * Adding pipeline * del jenkinsfile * Make exec agent not to use setsid for other than Linux envs * revert pom.xml * goformat * get projects folder from workkspace configuration * Merge remote-tracking branch 'upstream/master' * clean code * clean code * Fix calculation Projects Root so it wont cause NPE if there are no 'project' volume defined * Revert "Fix calculation Projects Root so it wont cause NPE if there are no 'project' volume defined" This reverts commit 127a79e. * Fix calculation Projects Root so it wont cause NPE if there are no 'project' volume defined * replace provided attribute values with stored (src, out) in PlainJavaProjectType * fix PlainJavaProjectType for getting rid and deprecate using SettableValueProvider * remove comented code * hide brouse source folder button, set source folder field as disabled * hide the browse source button, set source folder field to read only mode, remove highlighter from the source folder field * adapt test for current changes on UI, set save button to enable state * apply formatting * fix order of steps in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make PlainJavaExtension's ValueProvider read-only (if was the last PT using settable one) and deprecate SettableValueProvider.
What issues does this PR fix or reference?
To simplify project type framework getting rid of not useful SettableValueProvider
Release Notes
N/A
Docs PR
N/A