Send initialized event, after initialization #9776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
vparfonov
changed the title
benoitf
added
the
status/code-review
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
|
ci-test |
|
ci-test build report: |
|
After first running the selenium tests, some tests fell (there were some problems on github side). But after relaunching they passed. Also were checked LS servers by manual test plan. The LS like TypeScript, Clang were checked on Docker infrastructure, because on OpenShift infrastructure this LS demand root privileges. This will be fixed in near time. |
musienko-maxim
approved these changes
May 23, 2018
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
vparfonov
changed the title
dkuleshov
approved these changes
May 23, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
* Send initialized event, after initialization Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Parfonov vparfonov@redhat.com
What does this PR do?
According to the specification client must send
initializedmessage jaust after getting server capabilities. Looks like not all LS support this method we met this problem with LS's what we got from VS Code. Like GoLang ang C#What issues does this PR fix or reference?
#9351