Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize SeparationColumnType and RetentionIndexType #1176

Closed
eselmeister opened this issue Nov 6, 2022 · 1 comment
Closed

Harmonize SeparationColumnType and RetentionIndexType #1176

eselmeister opened this issue Nov 6, 2022 · 1 comment
Assignees

Comments

@eselmeister
Copy link
Contributor

Over the years, two strategies how to handle column specific retention index values have been added and used. Hence, both

  • RetentionIndexType
  • SeparationColumnType

shall be harmonized to enable modifying the column mapping at a central place instead of several:

Screenshot from 2022-11-06 08-07-50

Screenshot from 2022-11-06 08-08-16

Screenshot from 2022-11-06 08-08-45

Screenshot from 2022-11-06 08-09-03

org.eclipse.chemclipse.model.core.RetentionIndexType
org.eclipse.chemclipse.model.columns.SeparationColumnType

RetentionIndexType mappings in *.msl, *.msp and *.cal files.

Parse Separation Column from Header
org.eclipse.chemclipse.msd.converter.ui.ConverterPreferencePage
org.eclipse.chemclipse.swt.ui.preferences.PreferencePageSystem
@eselmeister eselmeister self-assigned this Nov 6, 2022
@eselmeister
Copy link
Contributor Author

As this task will be complex and requires the modification of several positions in the source code to ensure backward compatibility, I'll personally take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant