Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Procedures in the processing API #120

Closed
laeubi opened this issue Nov 19, 2019 · 2 comments
Closed

Support Procedures in the processing API #120

laeubi opened this issue Nov 19, 2019 · 2 comments
Assignees
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Nov 19, 2019

Currently we can execute Methods, butt these are always working on the same input data.
What is missing is something like a procedure/function call where one can transform the data in some way, pass it down to an execution pipeline and then proceed with the original data set.
Whether or not this has influence on the data itself will not be restricted, for example a workflow might work like this:

  • A ChromatogramSelection is processed by some processors
  • then a Procedure reads a chromatogram from a file, process it with some sub-steps and link that chromatogram with the original one by putting it to the ReferencedChromatograms
  • now other steps can follow working on the original chromatogramselection enhanced by the Reference Chromatogram

Another workflow might do the following:

  • A ChromatogramSelection is processed by some processors
  • Then a procedure extracts a given Reference Chromatogram (e.g. always index 1) and write it to a file
  • now other steps that follow will still see the original chromatogramselection without any changes

To keep things simple an clear, we won't allow a procedure to actually change the type of data processed (this will be the are of a Transformer), so procedures are just a way to branch out the processing of the same type to perform some substeps, but for example do not allow to convert a Chromatogram to a peaklist and then process on peaklists.

@laeubi laeubi self-assigned this Nov 19, 2019
@laeubi laeubi closed this as completed in 0b0e354 Nov 19, 2019
@kerner1000
Copy link
Contributor

then a Procedure reads a chromatogram from a file, process it with some sub-steps and link that chromatogram with the original one by putting it to the ReferencedChromatograms

It would also be useful if it would be possible to open a new chromatogram editor based on another chromatogram selection or modified chromatogram.

@laeubi
Copy link
Member Author

laeubi commented Nov 26, 2019

This is tracked here: #99

@laeubi laeubi added this to the 0.8.x milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants