Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantitation Bundle - refactor bundle name #1223

Closed
eselmeister opened this issue Dec 23, 2022 · 1 comment
Closed

Quantitation Bundle - refactor bundle name #1223

eselmeister opened this issue Dec 23, 2022 · 1 comment

Comments

@eselmeister
Copy link
Contributor

Currently, the bundles are named:

org.eclipse.chemclipse.chromatogram.msd.quantitation
org.eclipse.chemclipse.chromatogram.msd.quantitation.supplier.chemclipse

Meanwhile, both support not only GC-MS but also GC-FID data. Hence, the bundle name shall be refactored to signalize that various detectors are supported. The following extension ids shall be preserved to ensure, that existing process methods still work.

id="org.eclipse.chemclipse.chromatogram.msd.quantitation.supplier.chemclipse.peak.estd"
id="org.eclipse.chemclipse.chromatogram.msd.quantitation.supplier.chemclipse.peak.istd"
id="org.eclipse.chemclipse.chromatogram.msd.quantitation.supplier.chemclipse.ui.add.peaks.estd"
@eselmeister
Copy link
Contributor Author

The following bundles have been removed as they were empty and not needed any longer:

org.eclipse.chemclipse.chromatogram.csd.quantitation
org.eclipse.chemclipse.chromatogram.csd.quantitation.ui
org.eclipse.chemclipse.chromatogram.quantitation
org.eclipse.chemclipse.chromatogram.quantitation.ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant