Revamp PCR tabular reporting settings #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
pcr-report-settings
branch
from
5387e50
to
91cefca
Compare
eselmeister
reviewed
Sep 5, 2023
...org/eclipse/chemclipse/pcr/report/supplier/tabular/excel/preferences/PreferenceSupplier.java
Outdated
Show resolved
Hide resolved
eselmeister
reviewed
Sep 5, 2023
...org/eclipse/chemclipse/pcr/report/supplier/tabular/excel/preferences/PreferenceSupplier.java
Outdated
Show resolved
Hide resolved
eselmeister
reviewed
Sep 5, 2023
...org/eclipse/chemclipse/pcr/report/supplier/tabular/excel/preferences/PreferenceSupplier.java
Outdated
Show resolved
Hide resolved
Mailaender
force-pushed
the
pcr-report-settings
branch
from
91cefca
to
c3bd669
Compare
Mailaender
force-pushed
the
pcr-report-settings
branch
from
c3bd669
to
9f6e017
Compare
Mailaender
force-pushed
the
pcr-report-settings
branch
from
9f6e017
to
042f37f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves usability on top of #1086 and #1493. The settings were hard to find and navigate. My idea of having all tables in one page also turned out to be a disaster for layouting so I split them and added some descriptions. There was also an annoying bug where the resulting column width was wrong for reports which got empty columns removed. As a goody you can now automatically open the human readable spreadsheet report inspired by #1476.