Some minor updates to the Explorer UI #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep readability when peak scan list is opened as well.
Mailaender
force-pushed
the
l10n-ux-extension
branch
from
c583487
to
81fbd00
Compare
eselmeister
reviewed
Nov 14, 2023
| @@ -263,7 +263,7 @@ private void updateStyle(int style) { | |||
| fontSize = 18; | |||
| } | |||
| // | |||
| Font font = new Font(getDisplay(), "Arial", fontSize, SWT.BOLD); | |||
| Font font = new Font(getDisplay(), "Arial", fontSize, SWT.BOLD); //$NON-NLS-1$ | |||
There was a problem hiding this comment.
To harmonize using fonts, you could use
org.eclipse.chemclipse.swt.ui.support.Fonts
getCachedFont(...)
or the default Font selection
org.eclipse.swtchart/src/org/eclipse/swtchart/Resources.java
Resources.DEFAULT_FONT_NAME
|
Looks good. I have added a comment, which could be addressed in a next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including localization and avoiding redundancy in the labels to save some horizontal space.