Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the CLI Interface with method support #405

Closed
laeubi opened this issue Aug 26, 2020 · 7 comments
Closed

Enhance the CLI Interface with method support #405

laeubi opened this issue Aug 26, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@laeubi
Copy link
Member

laeubi commented Aug 26, 2020

Currently the CLI Support is very limited, we can easily extend this to a general purpose interface by making the process methods available here.

The following things are needed to support this:

  1. There must be a way to load one or more chromatograms into a shared context
  2. There must be a way to load and execute a method using the previously loaded chromatograms
  3. To support processors that require UI interaction, there should be a "GUI Mode" where the UI is started and afterwards shutdown
@laeubi laeubi added the enhancement New feature or request label Aug 26, 2020
@laeubi laeubi self-assigned this Aug 26, 2020
@laeubi laeubi closed this as completed in 20770ac Aug 26, 2020
@eselmeister
Copy link
Contributor

@laeubi The bundle name doesn't match the ChemClipse name conventions. It contains UI code, hence it should be named

  • org.eclipse.chemclipse.cli.ui

instead of

  • org.eclipse.chemclipse.cli

Please fix this.

@laeubi
Copy link
Member Author

laeubi commented Sep 1, 2020

No further action from my side, cli has nothing to do with ui/not ui and only references necessary dependencies.

@eselmeister
Copy link
Contributor

@waynebeaton
@laeubi: Have you renamed the bundle accordingly to the ChemClipse bundle naming pattern?

@eselmeister eselmeister reopened this Sep 1, 2020
@laeubi
Copy link
Member Author

laeubi commented Sep 1, 2020

Feel free to take over or keep this issue open if you think anything needs to be doe here. The original issue "Enhance the CLI Interface with method support" is resolved regardless of naming of a binary artifact.

@eselmeister
Copy link
Contributor

@waynebeaton
@laeubi It's not an issue of the binary artifact, but of the consistency of the bundle naming. If a bundle contains at least one UI dependency (SWT or other), then "ui" should be included in the bundle name, see:

  • org.eclipse.chemclipse.ux.extension.xxd.ui
  • org.eclipse.chemclipse.xxd.converter.supplier.chemclipse.ui
  • org.eclipse.chemclipse.logging.ui
  • org.eclipse.chemclipse.csd.converter.ui
  • ...

You are a project lead. You should be aware of it. If you haven't been aware of it yet, you know it now. Please adjust the bundle name. Thanks.

@eselmeister
Copy link
Contributor

@waynebeaton
@laeubi Christoph, are you unable or unwilling to adjust the bundle name?

@eselmeister
Copy link
Contributor

OK, I understand. You are unwilling to work in a team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants