Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw more attention to Stopped Codewind item #156

Closed
thisguy-1 opened this issue Aug 9, 2019 · 9 comments

Comments

@thisguy-1
Copy link

commented Aug 9, 2019

It's a good attention grabber. @tetchel

@tetchel

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

This is a limitation of the VS Code treeview API, inline buttons only show when the item is selected. We can force focus but that would hijack keyboard focus which would be very annoying for the user. I'm not sure what else I could do

@thisguy-1

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Hijacking would not be good. If it cant be done it cant be done.

@thisguy-1

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Can this at least happen the first time a person click on "open workspace"? It does feel logical that you would want to go there.

@tetchel

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

For starters, I opened microsoft/vscode#78829

I can see about selecting it just once, but since users are generally clicking a lot of the time anyway I'm not sure they would even notice the selection (since it would be lost as soon as they click).

@thisguy-1

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Gotcha. Then lets not do this. Hopefully with it opening up, that will be sufficient. When it is open, is possible for the entire tree line be extended as well? (showing the the projects icon, and the click here to create...)?

@tetchel

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

When it is open, is possible for the entire tree line be extended as well?

It does do that once CW is started. What would it show if it's stopped?

@thisguy-1

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Projects (Connecting)>(Local)>(Disconnected)?
Something like that? Any ideaS @sishida ?

Or maybe just show the Projects Icon. Though it would be weird without anything in () and then getting the local status.

@sishida

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I'd have to see this in action to get a better idea of context, but if we want to show how a project is connecting, able to be used locally, and then disconnected, then I think that @thisguy-1's suggestion works.

@tetchel

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

We can't make this change, but I will change the Stopped tree item to say Stopped on it which should draw some more attention to it as how to Start things.

@tetchel tetchel changed the title "On/Off" Should be Sticky Draw more attention to Stopped Codewind item Sep 4, 2019
tetchel added a commit to tetchel/codewind-vscode that referenced this issue Sep 5, 2019
remove some unneeded code and rename ProjectTree -> CodewindTree
Fix eclipse/codewind#156

Signed-off-by: Tim Etchells <timetchells@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.