Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the implementation more extensible by adding dependency injection #8

Open
waynebeaton opened this issue Feb 24, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@waynebeaton
Copy link
Member

Passing values (e.g. the settings, and logging) around via constructors is cumbersome. Further, things like the ContentIdParsers should be configurable and extendable (e.g., the FlatFileReader constructor hardcodes the parsers that it uses, this should be extendable). Dependency injection will make this sort of configuration easier.

@waynebeaton waynebeaton mentioned this issue Feb 24, 2020
@waynebeaton waynebeaton added the help wanted Extra attention is needed label Feb 24, 2020
@waynebeaton
Copy link
Member Author

The IContext notion doesn't allow for extensibility. Dependency injection would likely be a better solution that would make it possible to, for example, reuse some of the services in a server-side process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant