-
Notifications
You must be signed in to change notification settings - Fork 214
/
ContentTypeValidationDirectiveTest.java
175 lines (145 loc) · 7.15 KB
/
ContentTypeValidationDirectiveTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
/*
* Copyright (c) 2020 Contributors to the Eclipse Foundation
*
* See the NOTICE file(s) distributed with this work for additional
* information regarding copyright ownership.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0
*
* SPDX-License-Identifier: EPL-2.0
*/
package org.eclipse.ditto.gateway.service.endpoints.directives;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.catchThrowableOfType;
import static org.eclipse.ditto.gateway.service.endpoints.directives.ContentTypeValidationDirective.ensureValidContentType;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import java.util.Map;
import java.util.Set;
import java.util.function.Supplier;
import org.eclipse.ditto.base.model.common.HttpStatus;
import org.eclipse.ditto.base.model.exceptions.UnsupportedMediaTypeException;
import org.eclipse.ditto.base.model.headers.DittoHeaders;
import org.junit.Test;
import org.apache.pekko.http.javadsl.model.ContentType;
import org.apache.pekko.http.javadsl.model.ContentTypes;
import org.apache.pekko.http.javadsl.model.HttpHeader;
import org.apache.pekko.http.javadsl.model.HttpRequest;
import org.apache.pekko.http.javadsl.model.MediaTypes;
import org.apache.pekko.http.javadsl.model.StatusCodes;
import org.apache.pekko.http.javadsl.server.RequestContext;
import org.apache.pekko.http.javadsl.server.Route;
import org.apache.pekko.http.javadsl.testkit.JUnitRouteTest;
import org.apache.pekko.http.javadsl.testkit.TestRouteResult;
public final class ContentTypeValidationDirectiveTest extends JUnitRouteTest {
private final Supplier<Route> COMPLETE_OK = () -> complete(StatusCodes.OK);
@Test
public void testValidContentType() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final ContentType type = ContentTypes.APPLICATION_JSON;
// Act
final TestRouteResult result =
testRoute(extractRequestContext(
ctx -> ensureValidContentType(Set.of(type.mediaType().toString()), ctx, dittoHeaders,
COMPLETE_OK)))
.run(HttpRequest.PUT("someUrl").withEntity(type, "something".getBytes()));
// Assert
result.assertStatusCode(StatusCodes.OK);
}
@Test
public void testNonValidContentType() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final String type = MediaTypes.APPLICATION_JSON.toString();
final ContentType differentType = ContentTypes.APPLICATION_X_WWW_FORM_URLENCODED;
final RequestContext mockedCtx = mock(RequestContext.class);
when(mockedCtx.getRequest())
.thenReturn(HttpRequest.PUT("someUrl").withEntity(differentType,"something".getBytes()));
// Act
final UnsupportedMediaTypeException result =
catchThrowableOfType(() -> ensureValidContentType(Set.of(type), mockedCtx, dittoHeaders, COMPLETE_OK),
UnsupportedMediaTypeException.class);
// Assert
assertThat(result).hasMessageContaining(differentType.toString());
assertThat(result.getHttpStatus()).isEqualTo(HttpStatus.UNSUPPORTED_MEDIA_TYPE);
}
@Test
public void testWithContentTypeWithoutCharset() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final String type = MediaTypes.TEXT_PLAIN.toString();
final ContentType typeMissingCharset = MediaTypes.TEXT_PLAIN.toContentTypeWithMissingCharset();
// Act
final TestRouteResult result =
testRoute(extractRequestContext(
ctx -> ensureValidContentType(Set.of(type), ctx, dittoHeaders, COMPLETE_OK)))
.run(HttpRequest.PUT("someUrl").withEntity(typeMissingCharset, "something".getBytes()));
// Assert
result.assertStatusCode(StatusCodes.OK);
}
@Test
public void testWithoutEntityNoNPEExpected() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final String type = ContentTypes.APPLICATION_JSON.mediaType().toString();
final RequestContext mockedCtx = mock(RequestContext.class);
when(mockedCtx.getRequest()).thenReturn(HttpRequest.PUT("someUrl"));
// Act
final UnsupportedMediaTypeException result =
catchThrowableOfType(() -> ensureValidContentType(Set.of(type), mockedCtx, dittoHeaders, COMPLETE_OK),
UnsupportedMediaTypeException.class);
// Assert
assertThat(result.getHttpStatus()).isEqualTo(HttpStatus.UNSUPPORTED_MEDIA_TYPE);
}
@Test
public void testExceptionContainsDittoHeaders() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.of(Map.of("someHeaderKey", "someHeaderVal"));
final String type = ContentTypes.APPLICATION_JSON.mediaType().toString();
final RequestContext mockedCtx = mock(RequestContext.class);
when(mockedCtx.getRequest()).thenReturn(HttpRequest.PUT("someUrl"));
// Act
final UnsupportedMediaTypeException result =
catchThrowableOfType(() -> ensureValidContentType(Set.of(type), mockedCtx, dittoHeaders, COMPLETE_OK),
UnsupportedMediaTypeException.class);
// Assert
assertThat(result.getDittoHeaders()).isEqualTo(dittoHeaders);
}
/**
* When pekko can't parse the content-type header, it appears as rawHeader and application/octet-streams is used
* as default, this behaviour is simulated here.
*/
@Test
public void testWithNonParsableContentType() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final String nonParsableMediaType = "application-json";
// Act
final TestRouteResult result =
testRoute(extractRequestContext(
ctx -> ensureValidContentType(Set.of(nonParsableMediaType), ctx, dittoHeaders, COMPLETE_OK)))
.run(HttpRequest.PUT("someUrl")
.addHeader(HttpHeader.parse("content-type", nonParsableMediaType))
.withEntity(ContentTypes.APPLICATION_OCTET_STREAM, "something".getBytes()));
// Assert
result.assertStatusCode(StatusCodes.OK);
}
@Test
public void testWithUpperCaseContentTypeHeaderName() {
// Arrange
final DittoHeaders dittoHeaders = DittoHeaders.empty();
final String type = MediaTypes.APPLICATION_JSON.toString();
// Act
final TestRouteResult result =
testRoute(extractRequestContext(
ctx -> ensureValidContentType(Set.of(type), ctx, dittoHeaders, COMPLETE_OK)))
.run(HttpRequest.PUT("someUrl")
.addHeader(HttpHeader.parse("CONTENT-TYPE", type))
.withEntity(ContentTypes.APPLICATION_OCTET_STREAM, "something".getBytes()));
// Assert
result.assertStatusCode(StatusCodes.OK);
}
}