change permission check to have unrestricted permission for live events;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
eclipse-ditto · Sep 29, 2021 · 00a38d5 · 00a38d5
1 parent 93858ef
commit 00a38d5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.../src/main/java/org/eclipse/ditto/concierge/service/enforcement/LiveSignalEnforcement.java b/.../src/main/java/org/eclipse/ditto/concierge/service/enforcement/LiveSignalEnforcement.java
@@ -243,7 +243,7 @@ private CompletionStage<Contextual<WithDittoHeaders>> enforceLiveSignal(final St
     private CompletionStage<Contextual<WithDittoHeaders>> enforceLiveEvent(final Signal<?> liveSignal,
             final Enforcer enforcer) {
 
-        final boolean authorized = enforcer.hasPartialPermissions(
+        final boolean authorized = enforcer.hasUnrestrictedPermissions(
                 PoliciesResourceType.thingResource(liveSignal.getResourcePath()),
                 liveSignal.getDittoHeaders().getAuthorizationContext(), WRITE);
 

diff --git a/.../test/java/org/eclipse/ditto/concierge/service/enforcement/LiveSignalEnforcementTest.java b/.../test/java/org/eclipse/ditto/concierge/service/enforcement/LiveSignalEnforcementTest.java
@@ -344,7 +344,7 @@ public void acceptLiveEventByPolicyWithRestrictedPermissions() {
                 .setRevision(1L)
                 .forLabel("authorize-self")
                 .setSubject(GOOGLE, SUBJECT_ID)
-                .setGrantedPermissions(PoliciesResourceType.thingResource("/attributes/foo/bar"),
+                .setGrantedPermissions(PoliciesResourceType.thingResource("/attributes"),
                         Permissions.newInstance(Permission.READ, Permission.WRITE))
                 .setRevokedPermissions(PoliciesResourceType.thingResource("/attributes/xyz/abc"),
                         Permissions.newInstance(Permission.READ, Permission.WRITE))

diff --git a/...c/main/java/org/eclipse/ditto/gateway/service/streaming/actors/StreamingSessionActor.java b/...c/main/java/org/eclipse/ditto/gateway/service/streaming/actors/StreamingSessionActor.java
@@ -486,7 +486,7 @@ private void forwardAcknowledgementOrLiveCommandResponse(final CommandResponse<?
                     .ifPresentOrElse(
                             forwarder -> forwarder.tell(response, sender),
                             () -> {
-                                // the Acknowledgement / live CommandResponse is meant for someone else:
+                                // the Acknowledgement / LiveCommandResponse is meant for someone else:
                                 final var template =
                                         "No AcknowledgementForwarderActor found, forwarding to concierge: <{}>";
                                 if (logger.isDebugEnabled()) {