Skip to content

Commit

Permalink
Revert "Add logger for connection validation exception"
Browse files Browse the repository at this point in the history
This reverts commit 11bf8b4.
  • Loading branch information
DerSchwilk committed Oct 26, 2022
1 parent 5a207f8 commit 03ba89c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import org.eclipse.ditto.connectivity.model.signals.commands.exceptions.ConnectionNotAccessibleException;
import org.eclipse.ditto.connectivity.model.signals.events.ConnectivityEvent;
import org.eclipse.ditto.connectivity.service.messaging.persistence.stages.ConnectionState;
import org.eclipse.ditto.internal.utils.akka.logging.DittoLoggerFactory;
import org.eclipse.ditto.internal.utils.persistentactors.commands.AbstractCommandStrategy;

/**
Expand Down Expand Up @@ -85,9 +84,6 @@ static Optional<DittoRuntimeException> validate(final Context<ConnectionState> c
private static Optional<DittoRuntimeException> handleValidationException(
final Context<ConnectionState> context, final ConnectivityCommand<?> command,
final Exception error) {

DittoLoggerFactory.getLogger(AbstractConnectivityCommandStrategy.class).error("Got an error whi8le validating" +
" connection", error);
final DittoRuntimeException dre =
toDittoRuntimeException(error, context.getState().id(), command.getDittoHeaders());
context.getLog().withCorrelationId(dre)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import org.eclipse.ditto.base.model.headers.DittoHeaders;
import org.eclipse.ditto.connectivity.model.Connection;
import org.eclipse.ditto.connectivity.model.signals.commands.ConnectivityCommand;
import org.eclipse.ditto.connectivity.model.signals.commands.ConnectivityCommandInterceptor;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
package org.eclipse.ditto.connectivity.service.messaging.validation;

import org.eclipse.ditto.base.model.headers.DittoHeaders;
import org.eclipse.ditto.internal.utils.akka.logging.DittoLoggerFactory;

/**
* Validates the given host.
Expand All @@ -37,7 +36,6 @@ interface HostValidator {
default void validateHostname(final String host, final DittoHeaders dittoHeaders) {
final HostValidationResult validationResult = validateHost(host);
if (!validationResult.isValid()) {
DittoLoggerFactory.getLogger(this.getClass()).error("hostname validation failed!", validationResult);
throw validationResult.toException(dittoHeaders);
}
}
Expand Down

0 comments on commit 03ba89c

Please sign in to comment.