Skip to content

Commit

Permalink
Issue #852: review: added missing "." at end of sentence of weak ack …
Browse files Browse the repository at this point in the history
…payload

* added missing "@SInCE" javadoc annotations to new public methods in Acknowledgement

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
  • Loading branch information
thjaeckle committed Nov 16, 2020
1 parent ea5f7f2 commit 116b2ca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Expand Up @@ -135,7 +135,7 @@ static Acknowledgement weakAck(final AcknowledgementLabel label,
final JsonValue payload = JsonValue.of("Acknowledgement was issued automatically as weak ack, " +
"because the signal is not relevant for the subscriber. Possible reasons are: " +
"the subscriber was not authorized, " +
"or the subscriber did not subscribe for the signal type");
"or the subscriber did not subscribe for the signal type.");
return Acknowledgement.weak(label, entityId, dittoHeaders, payload);
}

Expand Down
Expand Up @@ -88,6 +88,7 @@ static Acknowledgement of(final AcknowledgementLabel label,
* @param payload the optional payload of the Acknowledgement.
* @return the Acknowledgement.
* @throws NullPointerException if one of the required parameters was {@code null}.
* @since 1.5.0
*/
static Acknowledgement weak(final AcknowledgementLabel label,
final EntityIdWithType entityId,
Expand Down Expand Up @@ -139,6 +140,7 @@ static Acknowledgement of(final AcknowledgementLabel label,
* acknowledgement with this {@link #getLabel()}, but was for some reason not allowed to receive the signal.
*
* @return true if this is a weak acknowledgement, false otherwise.
* @since 1.5.0
*/
boolean isWeak();

Expand Down

0 comments on commit 116b2ca

Please sign in to comment.