#760 made small method more readable

Signed-off-by: Johannes Schneider <johannes.schneider@bosch.io>
eclipse-ditto · Aug 24, 2020 · 23e5c9f · 23e5c9f
1 parent 146ba30
commit 23e5c9f
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/.../main/java/org/eclipse/ditto/services/connectivity/messaging/MessageMappingProcessor.java b/.../main/java/org/eclipse/ditto/services/connectivity/messaging/MessageMappingProcessor.java
@@ -295,27 +295,22 @@ private static boolean shouldMapMessageByContentType(final ExternalMessage messa
     }
 
     private static boolean shouldMapMessageByConditions(final ExternalMessage message, final MessageMapper mapper) {
-        return validateMapperConditions(mapper, Resolvers.forExternalMessage(message));
+        return resolveConditions(mapper, Resolvers.forExternalMessage(message));
     }
 
-    private static boolean shouldMapMessageByConditions(final OutboundSignal.Mappable outboundSignal,
+    private static boolean shouldMapMessageByConditions(final OutboundSignal.Mappable mappable,
             final MessageMapper mapper) {
-        return validateMapperConditions(mapper, Resolvers.forOutboundSignal(outboundSignal));
+        return resolveConditions(mapper, Resolvers.forOutboundSignal(mappable));
     }
 
-    private static boolean validateMapperConditions(final MessageMapper mapper,
-            final ExpressionResolver expressionResolver) {
-        if (!mapper.getConditions().isEmpty()) {
-            boolean conditionBool = true;
-            ExpressionResolver resolver = expressionResolver;
-            for (String condition : mapper.getConditions()) {
-                conditionBool &= Boolean.parseBoolean(
-                        PlaceholderFilter.applyOrElseDelete("{{ fn:default('true') | " + condition + " }}", resolver)
-                                .orElse("false"));
-            }
-            return conditionBool;
+    private static boolean resolveConditions(final MessageMapper mapper, final ExpressionResolver resolver) {
+        boolean conditionBool = true;
+        for (String condition : mapper.getConditions()) {
+            final String template = "{{ fn:default('true') | " + condition + " }}";
+            final String resolvedCondition = PlaceholderFilter.applyOrElseDelete(template, resolver).orElse("false");
+            conditionBool &= Boolean.parseBoolean(resolvedCondition);
         }
-        return true;
+        return conditionBool;
     }
 
     private static Function<String, Boolean> filterByContentTypeBlocklist(final MessageMapper mapper) {