review: small code improvement;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
eclipse-ditto · Mar 11, 2022 · 2a56ccf · 2a56ccf
1 parent 4391e8a
commit 2a56ccf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...ditto/connectivity/model/signals/commands/query/RetrieveConnectionStatusResponseTest.java b/...ditto/connectivity/model/signals/commands/query/RetrieveConnectionStatusResponseTest.java
@@ -55,20 +55,20 @@
 public final class RetrieveConnectionStatusResponseTest {
 
     private static final Instant IN_CONNECTION_STATUS_SINCE = Instant.now();
-    private static List<ResourceStatus> clientStatus =
+    private static final List<ResourceStatus> clientStatus =
             Arrays.asList(
                     newClientStatus("client1", ConnectivityStatus.OPEN, RecoveryStatus.SUCCEEDED, "Client is connected",
                             IN_CONNECTION_STATUS_SINCE),
                     newClientStatus("client2", ConnectivityStatus.FAILED, RecoveryStatus.ONGOING,  "Client failed to connect.",
                             IN_CONNECTION_STATUS_SINCE.plusSeconds(3))
             );
-    private static List<ResourceStatus> sourceStatus =
+    private static final List<ResourceStatus> sourceStatus =
             Arrays.asList(
                     newSourceStatus("client1", ConnectivityStatus.OPEN, "source1","open since ..."),
                     newSourceStatus("client1", ConnectivityStatus.FAILED, "source1","this consumer fails ..."),
                     newSourceStatus("client1", ConnectivityStatus.CLOSED, "source2","closed since 123")
             );
-    private static List<ResourceStatus> targetStatus =
+    private static final List<ResourceStatus> targetStatus =
             Arrays.asList(
                     newTargetStatus("client1", ConnectivityStatus.OPEN, "target1","open since ..."),
                     newTargetStatus("client1", ConnectivityStatus.FAILED, "target2","this publisher fails ..."),

diff --git a/...e/src/test/java/org/eclipse/ditto/connectivity/service/messaging/BaseClientActorTest.java b/...e/src/test/java/org/eclipse/ditto/connectivity/service/messaging/BaseClientActorTest.java
@@ -245,8 +245,8 @@ private void ensureRecoveryStatus(final ActorRef dummyClientActor, final Connect
                     final RecoveryStatus unknown) {
                 dummyClientActor.tell(RetrieveConnectionStatus.of(randomConnectionId, DittoHeaders.empty()), getRef());
                 final ResourceStatus clientStatus = (ResourceStatus)
-                        fishForMessage(Duration.ofSeconds(1), "Client status", o -> o instanceof ResourceStatus rs &&
-                                rs.getResourceType() == ResourceStatus.ResourceType.CLIENT);
+                        fishForMessage(Duration.ofSeconds(1), "Client status", o -> o instanceof ResourceStatus rs
+                                && rs.getResourceType() == ResourceStatus.ResourceType.CLIENT);
                 assertThat(clientStatus.getRecoveryStatus()).contains(unknown);
             }
         };