Skip to content

Commit

Permalink
Switch to info level for misconfigured connectivity status
Browse files Browse the repository at this point in the history
* I try to avoid unnecessary warn logs
* For the purpose of using this log as source for a monitoring
  I used the live status in the ditto-log-tag mdc

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
  • Loading branch information
Yannic92 committed Jul 29, 2021
1 parent 61394a6 commit 3e110a0
Showing 1 changed file with 5 additions and 4 deletions.
Expand Up @@ -178,7 +178,7 @@ public final class ConnectionPersistenceActor

@Nullable private final ConnectivityCommandInterceptor customCommandValidator;
private ConnectivityCommandInterceptor commandValidator;
// Do nothing because nobody subscribes for connectivity events.
// Do nothing because nobody subscribes for connectivity events.

private ConnectivityCommandStrategies createdStrategies;
private ConnectivityCommandStrategies deletedStrategies;
Expand Down Expand Up @@ -466,18 +466,19 @@ private void askSelfForRetrieveConnectionStatus(@Nullable final String correlati
.whenComplete((response, throwable) -> {
if (response instanceof RetrieveConnectionStatusResponse) {
final RetrieveConnectionStatusResponse rcsResp = (RetrieveConnectionStatusResponse) response;
final ConnectivityStatus liveStatus = rcsResp.getLiveStatus();
final DittoDiagnosticLoggingAdapter l = log
.withMdcEntries(
ConnectivityMdcEntryKey.CONNECTION_ID.toString(), entityId,
CommonMdcEntryKey.DITTO_LOG_TAG, "connection-live-status"
CommonMdcEntryKey.DITTO_LOG_TAG,
"connection-live-status-" + liveStatus.getName()
)
.withCorrelationId(rcsResp);
final ConnectivityStatus liveStatus = rcsResp.getLiveStatus();
final String template = "Calculated <{}> live ConnectionStatus: <{}>";
if (liveStatus == ConnectivityStatus.FAILED) {
l.error(template, liveStatus, rcsResp);
} else if (liveStatus == ConnectivityStatus.MISCONFIGURED) {
l.warning(template, liveStatus, rcsResp);
l.info(template, liveStatus, rcsResp);
} else {
l.info(template, liveStatus, rcsResp);
}
Expand Down

0 comments on commit 3e110a0

Please sign in to comment.