Fixes duplicated stop of timer

Signed-off-by: Klem Yannic (INST/ECS1) <Yannic.Klem@bosch-si.com>
eclipse-ditto · Jul 10, 2018 · 7d914a1 · 7d914a1
1 parent ceab120
commit 7d914a1
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/...ipse/ditto/services/gateway/endpoints/directives/auth/jwt/JwtAuthenticationDirective.java b/...ipse/ditto/services/gateway/endpoints/directives/auth/jwt/JwtAuthenticationDirective.java
@@ -107,10 +107,10 @@ public Route authenticate(final String correlationId, final Function<Authorizati
                                     DirectivesLoggingUtils.enhanceLogWithCorrelationId(correlationId,
                                             () -> {
                                                 final PublicKey publicKey = publicKeyOpt
-                                                        .orElseThrow(() -> buildJwtUnauthorizedException(correlationId,
-                                                                timer));
+                                                        .orElseThrow(
+                                                                () -> buildJwtUnauthorizedException(correlationId));
 
-                                                validateToken(jwt, publicKey, correlationId, timer);
+                                                validateToken(jwt, publicKey, correlationId);
 
                                                 final List<AuthorizationSubject> authSubjects =
                                                         authorizationSubjectsProvider
@@ -155,22 +155,19 @@ private static DittoRuntimeException buildMissingJwtException(final String corre
     }
 
     private void validateToken(final JsonWebToken authorizationToken, final PublicKey publicKey,
-            final String correlationId, final StartedTimer timer) {
+            final String correlationId) {
         final DefaultJwtParser defaultJwtParser = new DefaultJwtParser();
 
         try {
             defaultJwtParser.setSigningKey(publicKey).parse(authorizationToken.getToken());
         } catch (final ExpiredJwtException | MalformedJwtException | SignatureException | IllegalArgumentException e) {
             LOGGER.info("Got Exception '{}' during parsing JWT: {}", e.getClass().getSimpleName(), e.getMessage(),
                     e);
-            throw buildJwtUnauthorizedException(correlationId, timer);
+            throw buildJwtUnauthorizedException(correlationId);
         }
     }
 
-    private static DittoRuntimeException buildJwtUnauthorizedException(final String correlationId,
-            final StartedTimer timer) {
-        timer.tag(TracingTags.AUTH_SUCCESS, false)
-                .stop();
+    private static DittoRuntimeException buildJwtUnauthorizedException(final String correlationId) {
 
         return GatewayAuthenticationFailedException.newBuilder("The JWT could not be verified")
                 .description("Check if your token is not expired and set the token accordingly.")