Report mongodb times as timer not as histogram

Signed-off-by: Klem Yannic (INST/ECS1) <Yannic.Klem@bosch-si.com>
eclipse-ditto · Jul 10, 2018 · 86dd671 · 86dd671
1 parent 42f03d5
commit 86dd671
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/...a/org/eclipse/ditto/services/utils/persistence/mongo/monitoring/KamonCommandListener.java b/...a/org/eclipse/ditto/services/utils/persistence/mongo/monitoring/KamonCommandListener.java
@@ -18,6 +18,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.mongodb.event.CommandEvent;
 import com.mongodb.event.CommandFailedEvent;
 import com.mongodb.event.CommandListener;
 import com.mongodb.event.CommandStartedEvent;
@@ -31,10 +32,11 @@
 public class KamonCommandListener implements CommandListener {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(KamonCommandListener.class);
-    private final String histogramPrefix;
+    private static final String COMMAND_NAME_TAG = "command_name";
+    private final String timerName;
 
     public KamonCommandListener(final String metricName) {
-        this.histogramPrefix = ConditionChecker.argumentNotEmpty(metricName, "metricName") + "_mongodb_";
+        this.timerName = ConditionChecker.argumentNotEmpty(metricName, "metricName") + "_mongodb_";
     }
 
     @Override
@@ -65,7 +67,7 @@ public void commandSucceeded(final CommandSucceededEvent event) {
 
         final long elapsedTime = event.getElapsedTime(TimeUnit.NANOSECONDS);
         final String commandName = event.getCommandName();
-        Kamon.histogram(TraceUtils.metricizeTraceUri(histogramPrefix + commandName)).record(elapsedTime);
+        recordElapsedTime(elapsedTime, commandName);
     }
 
     @Override
@@ -83,6 +85,10 @@ public void commandFailed(final CommandFailedEvent event) {
 
         final long elapsedTime = event.getElapsedTime(TimeUnit.NANOSECONDS);
         final String commandName = event.getCommandName();
-        Kamon.histogram(TraceUtils.metricizeTraceUri(histogramPrefix + commandName)).record(elapsedTime);
+        recordElapsedTime(elapsedTime, commandName);
+    }
+
+    private void recordElapsedTime(final long elapsedTime, final String commandName) {
+        Kamon.timer(TraceUtils.metricizeTraceUri(timerName)).refine(COMMAND_NAME_TAG, commandName).record(elapsedTime);
     }
 }