Review: ConnectionSupervisorActor

Signed-off-by: David Schwilk <david.schwilk@bosch.io>
eclipse-ditto · Jul 6, 2022 · a042bc1 · a042bc1
1 parent 2d413d8
commit a042bc1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/...rg/eclipse/ditto/connectivity/api/commands/sudo/ConnectivitySudoQueryCommandResponse.java b/...rg/eclipse/ditto/connectivity/api/commands/sudo/ConnectivitySudoQueryCommandResponse.java
@@ -26,7 +26,7 @@ public interface ConnectivitySudoQueryCommandResponse<T extends ConnectivitySudo
         SudoQueryCommandResponse<T> {
 
     /**
-     * Type Prefix of thing sudo command responses.
+     * Type Prefix of Connectivity sudo command responses.
      */
     String TYPE_PREFIX = "connectivity." + SUDO_TYPE_QUALIFIER;
 
@@ -42,7 +42,7 @@ default String getResourceType() {
     T setDittoHeaders(DittoHeaders dittoHeaders);
 
     /**
-     * An enumeration of the known {@link org.eclipse.ditto.json.JsonField}s of a Sudo Thing command response.
+     * An enumeration of the known {@link org.eclipse.ditto.json.JsonField}s of a Sudo Connectivity command response.
      */
     class JsonFields extends CommandResponse.JsonFields {
 

diff --git a/...ain/java/org/eclipse/ditto/connectivity/service/config/DittoConnectionConfigProvider.java b/...ain/java/org/eclipse/ditto/connectivity/service/config/DittoConnectionConfigProvider.java
@@ -34,21 +34,20 @@
  */
 public class DittoConnectionConfigProvider implements ConnectionConfigProvider {
 
-    private final ActorSystem actorSystem;
-
     public DittoConnectionConfigProvider(final ActorSystem actorSystem) {
-        this.actorSystem = actorSystem;
     }
 
     @Override
     public CompletionStage<Config> getConnectivityConfigOverwrites(final ConnectionId connectionId,
             @Nullable final DittoHeaders dittoHeaders) {
+
         return CompletableFuture.completedFuture(ConfigFactory.empty());
     }
 
     @Override
     public CompletionStage<Void> registerForConnectivityConfigChanges(final ConnectionId connectionId,
             @Nullable final DittoHeaders dittoHeaders, final ActorRef subscriber) {
+
         // nothing to do, config changes are not supported by the default implementation
         return CompletableFuture.completedStage(null);
     }

diff --git a/...g/eclipse/ditto/connectivity/service/messaging/persistence/ConnectionSupervisorActor.java b/...g/eclipse/ditto/connectivity/service/messaging/persistence/ConnectionSupervisorActor.java
@@ -90,6 +90,7 @@ public final class ConnectionSupervisorActor
     @SuppressWarnings("unused")
     private ConnectionSupervisorActor(final ActorRef commandForwarderActor, final ActorRef pubSubMediator,
             final ConnectionEnforcerActorPropsFactory enforcerActorPropsFactory) {
+
         super(null, CONNECTIVITY_DEFAULT_LOCAL_ASK_TIMEOUT);
         this.commandForwarderActor = commandForwarderActor;
         this.pubSubMediator = pubSubMediator;

diff --git a/...n/java/org/eclipse/ditto/internal/utils/persistence/mongo/streaming/MongoReadJournal.java b/...n/java/org/eclipse/ditto/internal/utils/persistence/mongo/streaming/MongoReadJournal.java
@@ -382,7 +382,6 @@ public Source<Document, NotUsed> getNewestSnapshotsAbove(final String lowerBound
         return getNewestSnapshotsAbove(lowerBoundPid, batchSize, false, mat, snapshotFields);
     }
 
-
     /**
      * Retrieve all latest snapshots with unique PIDs in snapshot store above a lower bound.
      * Does not limit database access in any way.