Skip to content

Commit

Permalink
removed X-Original-URI
Browse files Browse the repository at this point in the history
 - currently this header isn't handled by ditto
 - if someone were to make a large request with many thingIds in a GET request the X-Original-URI will be passed as a Ditto Header in the protocol message causing a DittoHeadersTooLarge exception -> http error 431
 - reverted kindest to 1.28.0 as images for 1.28.3 are no longer in docker.io

Signed-off-by: Kalin Kostashki <kalin.kostashki@bosch.com>
  • Loading branch information
kalinkostashki committed Nov 27, 2023
1 parent 2d49083 commit f5dfbeb
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/helm-chart.yml
Expand Up @@ -94,7 +94,7 @@ jobs:
k8s:
- v1.26.6
- v1.27.3
- v1.28.3
- v1.28.0
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion deployment/helm/ditto/Chart.yaml
Expand Up @@ -16,7 +16,7 @@ description: |
A digital twin is a virtual, cloud based, representation of his real world counterpart
(real world “Things”, e.g. devices like sensors, smart heating, connected cars, smart grids, EV charging stations etc).
type: application
version: 3.4.1 # chart version is effectively set by release-job
version: 3.4.2 # chart version is effectively set by release-job
appVersion: 3.4.1
keywords:
- iot-chart
Expand Down
1 change: 0 additions & 1 deletion deployment/helm/ditto/templates/nginx-ingress.yaml
Expand Up @@ -131,7 +131,6 @@ data:
# ignore X-Original-URI in the request
proxy_hide_header X-Original-URI;
proxy_set_header X-Original-URI $request_uri;
proxy-connect-timeout: "10" # seconds, default: 60
# timeouts are configured slightly higher than gateway read-timeout of 60 seconds
Expand Down

0 comments on commit f5dfbeb

Please sign in to comment.