add private constructor for ShardRegionCreator;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
eclipse-ditto · Aug 24, 2022 · ff52956 · ff52956
1 parent 4fb6cdf
commit ff52956
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/...ls/cluster/src/main/java/org/eclipse/ditto/internal/utils/cluster/ShardRegionCreator.java b/...ls/cluster/src/main/java/org/eclipse/ditto/internal/utils/cluster/ShardRegionCreator.java
@@ -29,6 +29,10 @@
 @NotThreadSafe
 public final class ShardRegionCreator {
 
+    private ShardRegionCreator() {
+        throw new AssertionError();
+    }
+
     /**
      * Create a shard region using a custom hand-off message.
      *
@@ -41,17 +45,18 @@ public final class ShardRegionCreator {
      */
     public static ActorRef start(final ActorSystem system, final String shardRegionName,
             final Props props, final int numberOfShards, final String clusterRole) {
-
         final var extractor = ShardRegionExtractor.of(numberOfShards, system);
+
         return start(system, shardRegionName, props, extractor, clusterRole);
     }
 
     static ActorRef start(final ActorSystem system, final String shardRegionName, final Props props,
             final ShardRegion.MessageExtractor extractor, final String clusterRole) {
-
         final var clusterSharding = ClusterSharding.get(system);
         final var settings = ClusterShardingSettings.create(system).withRole(clusterRole);
         final var strategy = clusterSharding.defaultShardAllocationStrategy(settings);
+
         return clusterSharding.start(shardRegionName, props, settings, extractor, strategy, new StopShardedActor());
     }
+
 }
diff --git a/...luster/src/test/java/org/eclipse/ditto/internal/utils/cluster/ShardRegionCreatorTest.java b/...luster/src/test/java/org/eclipse/ditto/internal/utils/cluster/ShardRegionCreatorTest.java
@@ -69,7 +69,7 @@ public void terminateActorSystems() {
     }
 
     @Test
-    public void testHandOffMessage() throws Exception {
+    public void testHandOffMessage() {
         new TestKit(system2) {{
             // GIVEN: 2 actor systems form a cluster with shard regions started on both
             final var props = Props.create(MessageForwarder.class, getRef());
@@ -146,7 +146,7 @@ public void testSelfRestart() {
             // THEN: the sharded actor receives the hand-off message
             expectMsgClass(StopShardedActor.class);
 
-            // WHEN: the sharded actor queues another message to self before stoppin
+            // WHEN: the sharded actor queues another message to self before stopping
             firstShardedActor.tell(MessageForwarder.MESSAGE_SHARD, getRef());
             expectMsg(MessageForwarder.MESSAGE_SHARD);
             firstShardedActor.tell(PoisonPill.getInstance(), getRef());
@@ -162,6 +162,7 @@ public void testSelfRestart() {
     private static boolean isShardedActorIn(final ActorRef shardedActor, final ActorSystem system) {
         final var relativePath =
                 shardedActor.path().elements().drop(1).reduce((x, y) -> x + "/" + y).toString();
+
         return ActorSelection.apply(system.systemImpl().systemGuardian(), relativePath)
                 .resolveOne(java.time.Duration.ofSeconds(10))
                 .thenApply(result -> true)
@@ -216,5 +217,7 @@ public Receive createReceive() {
                     .matchAny(message -> receiver.tell(message, getSelf()))
                     .build();
         }
+
     }
+
 }