New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easy to add new Authentication mechanisms and allow chaining them #348

Closed

Yannic92 opened this issue Mar 8, 2019 · 1 comment

Milestone

Contributor

Yannic92 commented Mar 8, 2019

Right now it is not possible to chain multiple authentication mechanisms that are all applicable to a given request.

Behaviour now: First applicable authentication mechanism is used and if authentication fails, the "chain" will be interrupted.

Desired behaviour: If we have multiple applicable authentication mechanisms all of them should be processed until either one of them authenticates successfully or all of them fail.

Example use case:

We implement for example two different authentication providers.
Both are getting their credentials from Basic Auth (both are applicable for a request sending an authorization type containing basic auth).
First try one of them and if this authentication fails we should try the other one

thjaeckle added the in progress label

thjaeckle added this to the 0.9.0-M1 milestone

thjaeckle mentioned this issue

Eclipse Ditto on Microsoft Azure #358

Closed

thjaeckle removed this from the 0.9.0-M1 milestone

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Authentication Refactoring

* Refactor AuthenticationDirectives to AuthenticationProviders
* Use one single AuthenticationDirective
* Allow to chain authentication providers
** first successful authentication counts
* Moves AuthenticationProviders to security package instead of endpoint

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Increases Timeout for messages to make tests…

3cfe0f6

… more stable

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: fix deprecation warnings in QueryActorTest

88ed063

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: use blocking dispatcher for authentication c…

505a980

…hain

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Authentication providers don't need to be en…

64e365d

…sure they are running asnyc.

* It's already ensured in AuthenticationChain.
* Eliminates risk of dead lock (blocking dispatcher out of threads)

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Validate number of parts of the JWT

196ede1

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Refactored constructor to make it easier to …

23256cf

…understand.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Minor refactorings and adjustments of Javado…

5975c95

…c comments and code formatting. Do not check twice if AuthenticationChain is applicable.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Fixed unit test.

6e78ea0

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Use CharSequence for correlation ID where …

4da004c

…possible. Adjusted some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Added missing "@throws" documentation.

54cae50

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Improved logging with correlation ID.

ae4f5c1

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Include external Ditto headers in HTTP respo…

746bbc2

…nses sent within RootRoute.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Updated license header configuration. TODO: …

d2f7b8f

…enable "failIfMissing" after having updated all copyright headers in files.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Authentication Refactoring

82920b3

* Refactor AuthenticationDirectives to AuthenticationProviders
* Use one single AuthenticationDirective
* Allow to chain authentication providers
** first successful authentication counts
* Moves AuthenticationProviders to security package instead of endpoint

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Increases Timeout for messages to make tests…

1779c10

… more stable

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: fix deprecation warnings in QueryActorTest

5e16952

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: use blocking dispatcher for authentication c…

07ca4c6

…hain

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Authentication providers don't need to be en…

9d808e0

…sure they are running asnyc.

* It's already ensured in AuthenticationChain.
* Eliminates risk of dead lock (blocking dispatcher out of threads)

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Validate number of parts of the JWT

03de1b9

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Refactored constructor to make it easier to …

b611a08

…understand.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Minor refactorings and adjustments of Javado…

a8b8a58

…c comments and code formatting. Do not check twice if AuthenticationChain is applicable.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Fixed unit test.

28f1047

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Use CharSequence for correlation ID where …

961dc5d

…possible. Adjusted some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Added missing "@throws" documentation.

4ae9bf8

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Improved logging with correlation ID.

c1fe320

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Fixed unit test.

6ec6799

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Use CharSequence for correlation ID where …

a79571f

…possible. Adjusted some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Added missing "@throws" documentation.

f7c42c2

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Improved logging with correlation ID.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Include external Ditto headers in HTTP respo…

afcc310

…nses sent within RootRoute.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Updated license header configuration. TODO: …

0aa2da9

…enable "failIfMissing" after having updated all copyright headers in files.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: reenable license header check

af5c3f3

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: update licence headers

109ad2e

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Package restructuring

c09faed

* Moves Entry to cache utils
* Moves AbstractPubSubListenerActor to cluster utils

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: change name of blocking-dispatcher to authen…

2fbc971

…tication-dispatcher

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: make authentication-dispatcher more flexible

7fdd697

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Refactored constructor to make it easier to …

1b8e483

…understand.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Minor refactorings and adjustments of Javado…

9c0d16f

…c comments and code formatting. Do not check twice if AuthenticationChain is applicable.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Fixed unit test.

52d82fd

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Use CharSequence for correlation ID where …

e622eee

…possible. Adjusted some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Added missing "@throws" documentation.

5adac4e

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Improved logging with correlation ID.

0474fe7

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Include external Ditto headers in HTTP respo…

3b62011

…nses sent within RootRoute.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 pushed a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Updated license header configuration. TODO: …

babdbd5

…enable "failIfMissing" after having updated all copyright headers in files.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: reenable license header check

06d4524

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: update licence headers

9e608dc

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: Package restructuring

caee076

* Moves Entry to cache utils
* Moves AbstractPubSubListenerActor to cluster utils

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: change name of blocking-dispatcher to authen…

313b5f3

…tication-dispatcher

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: make authentication-dispatcher more flexible

a1c41fc

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

Yannic92 mentioned this issue

Feature/unify authentication #377

Merged

Yannic92 added a commit to bosch-io/ditto that referenced this issue


          Issue eclipse-ditto#348: add missing import

4428b36

Signed-off-by: Klem Yannic (INST/ECS1) <yannic.klem@bosch-si.com>

jufickel-b commented Apr 9, 2019

Fixed with PR #377.

jufickel-b closed this as completed

thjaeckle removed the in progress label

thjaeckle added this to the 0.9.0-M2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment