Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of ThingDeleteModel always consider model as not outdated #1368

Merged
merged 3 commits into from Apr 17, 2022
Merged

In case of ThingDeleteModel always consider model as not outdated #1368

merged 3 commits into from Apr 17, 2022

Conversation

Yannic92
Copy link
Contributor

See java comment:

             * This branch is required because missed ThingDeletes will always have revision -1.
             * This also comes with a downside that it can happen that a thing delete model will come after a create
             * model in wrong order, so the thing will be removed from the index incorrectly.
             * However, in this case the thing will become eventually consistent either by the next background sync or
             * the next update.

@Yannic92
In case of ThingDeleteModel always consider model as not outdated
26d1b59 
Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
@thjaeckle thjaeckle added this to the 2.4.1 milestone Apr 14, 2022
@Yannic92
Remove extra condition as the assumption that revision is always -1 w…
4d9372a 
…as wrong

Signed-off-by: Yannic Klem <Yannic.Klem@bosch.io>
@yufei-cai yufei-cai self-requested a review April 14, 2022 14:26
@yufei-cai
Amend ThingUpdaterTest#refuseToPerformOutOfOrderUpdate.
ed7064a 
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
yufei-cai
yufei-cai approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@yufei-cai yufei-cai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yufei-cai yufei-cai merged commit 6e6031c into eclipse-ditto:master Apr 17, 2022
@yufei-cai yufei-cai deleted the bugfix/delete-missed-thing-deletio branch April 17, 2022 15:08
@thjaeckle
Copy link
Member

-> cherry-picked 3 commits to release-2.4 branch

@thjaeckle thjaeckle modified the milestones: 2.4.1, 2.5.0 Jun 22, 2022
@thjaeckle thjaeckle modified the milestones: 2.5.0, 3.0.0 Jul 4, 2022
@thjaeckle thjaeckle modified the milestones: 3.0.0, 2.4.1 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufei-cai yufei-cai yufei-cai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yannic92 @thjaeckle @yufei-cai