Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose a patch for fixing failing test #151

Merged
merged 1 commit into from
May 3, 2018
Merged

Propose a patch for fixing failing test #151

merged 1 commit into from
May 3, 2018

Conversation

lucesape
Copy link
Contributor

@lucesape lucesape commented May 3, 2018

No description provided.

@thjaeckle
Copy link
Member

thjaeckle commented May 3, 2018 •
edited
Loading

Thank you very much for your PR.

Could you please take the steps in our CONTRIBUTING.md _ Legal requirements?
We can only accept PRs which come from users who signed the Eclipse Foundation Contributor License Agreement.

Afterwards your commit then also must be "singed off".

@lucesape
Propose a patch for failing test
7ab96e3 
Signed-off-by: Luc Esape <luc.esape@gmail.com>
@thjaeckle
Copy link
Member

Cool, thanks for going through the Eclipse process and for the fix.
And congrats to the first contribution to Eclipse Ditto from outside Bosch. 🥂

@thjaeckle thjaeckle merged commit b8846ed into eclipse-ditto:master May 3, 2018
@thjaeckle thjaeckle added this to the 0.3.0-M2 milestone May 3, 2018
@monperrus
Copy link

Hi @thjaeckle!
Full-disclosure, this pull-request was part of a scientific experiment, see https://medium.com/@martin.monperrus/human-competitive-patches-in-automatic-program-repair-with-repairnator-359042e00f6a
Thanks again for your welcoming attitude towards new contributors :-)
--Martin

@assert-bot assert-bot mentioned this pull request Oct 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0-M2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucesape @thjaeckle @monperrus