Enable support for MongoDB persistence in K8s #364

kaizimmerm · 2019-03-27T10:32:51Z

Hi,

small but practical improvement is to use persistent storage in the K8s setup for the MongoDB.

So I:

Migrated to the standard stable/mongodb chart which has this feature (and many more) already included.
Adapt the helm guide to the new chart.
Extended the Azure guide to leverage this using Azure storage.

Let me know what you think,

Kai

…ann <kai.zimmermann@microsoft.com>

ghandim · 2019-03-28T13:46:15Z

@kaizimmerm Why do you not connect a CosmosDB instance for a persistent storage example for ditto on Azure?

kaizimmerm · 2019-03-28T14:08:02Z

@ghandim I intend to look into this soon.

However, I would like to keep the MongoDB embedded option for test/dev purposes and especially there it is really annoying if you lose your data all the time.

Besides this patch will work in other K8s environments that have storage support as well. I hear there are other clouds next on Azure in existence, all balderdash of course 😈

Kai

ghandim · 2019-03-28T14:12:24Z

@kaizimmerm Good point :-) I will give it a try...

ghandim · 2019-03-28T15:33:32Z

deployment/azure/README.md

+
+...either with persistent storage
+
+```bash


@kaizimmerm I think you have to add here (cd ../helm/eclipse-ditto/ && helm dependency update). Otherwise you get a weird message from helm...

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim · 2019-03-29T14:58:22Z

deployment/azure/README.md

+...either with persistent storage
+
+```bash
+helm upgrade ditto ../helm/eclipse-ditto/ --namespace $k8s_namespace --set service.type=LoadBalancer,mongodb.persistence.enabled=true,mongodb.persistence.storageClass=managed-premium-retain --wait --install


@kaizimmerm Whats the advantage to use an own storage class definition instead of the default one? If I spin up ditto with helm upgrade ditto ../helm/eclipse-ditto/ --namespace $k8s_namespace --set service.type=LoadBalancer,mongodb.persistence.enabled=true --wait --install K8s generates a default persistent volume with from my point of view the same configuration as configured in managed-premium-retain.

@kaizimmerm Now I got it. The important difference is the retain policy.

ghandim · 2019-03-29T16:12:05Z

@kaizimmerm I think if we want to support the preservation of the mongodb data between complete reinstallations of ditto e.g. with helm delete --purge ditto than we have to introduce a pvc like

kind: PersistentVolumeClaim
metadata:
  name: mypvc
  namespace: dittons
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 8Gi
  storageClassName: managed-premium-retain

Then we can upgrade/install ditto without any data loss with

helm upgrade ditto ../helm/eclipse-ditto/ --namespace dittons --set service.type=LoadBalancer,mongodb.persistence.enabled=true,mongodb.persistence.existingClaim=mypvc --wait --install

With that it could be sufficient to use the default storage-class because the storage is deleted only when the pvc is deleted, or?

What do you think?

thjaeckle · 2019-04-01T06:05:11Z

Please ignore the Codacy check - I tried that out and it did "review" all open PRs

kaizimmerm · 2019-04-01T08:23:06Z

@ghandim yes, I guess that would work. I could add a paragraph on this to the helm guide. Agreed?

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim · 2019-04-01T11:06:23Z

@kaizimmerm With this pvc I was able to create a persistent reusable (default) storage in Azure AKS/Minikube:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ditto-pvc
  namespace: dittons
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 8Gi
#  storageClassName: <YOUR_STORAGE_CLASS>

To use the storage on Minikube in the namespace dittons you have to create ditto with

helm upgrade ditto ./eclipse-ditto/ --namespace dittons --set mongodb.persistence.enabled=true,mongodb.persistence.existingClaim=ditto-pvc --wait --install

On Azure:

helm upgrade ditto ../helm/eclipse-ditto/ --namespace dittons --set service.type=LoadBalancer,mongodb.persistence.enabled=true,mongodb.persistence.existingClaim=ditto-vpc --wait --install

So I think we should align also the helm documentation and use a separate namespace dittons and move the ditto-pvc to helm. Then also for the developers it is more clear that there are not many differences between the deployments on different environments.
What do you think?

kaizimmerm · 2019-04-01T12:04:02Z

@ghandim In Azure (and I assume other K8s setups as well) there are already PVCs pre setup. So I would make this an optional step in the helm guide.

kaizimmerm · 2019-04-01T12:08:01Z

@ghandim forget it, I mixed something up 😄 So I agree, I will adapt accordingly

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

kaizimmerm · 2019-04-01T12:25:42Z

@ghandim added it, let me know what you think

ghandim · 2019-04-01T14:47:41Z

deployment/helm/README.md

@@ -44,8 +44,32 @@ helm init

 ```bash
 cd <DITTO_PATH>/deployment/helm/
+kubectl create namespace dittons
 helm update dependencies


Path is missing here: helm dependencies update ./eclipse-ditto/

Fixed, good catch!

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim · 2019-04-01T15:01:22Z

deployment/helm/ditto-mongodb-pvc.yaml

+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: ditto-pvc


@kaizimmerm Should we name the pvc also ditto-mongodb-pvc?

ghandim · 2019-04-01T15:08:05Z

deployment/azure/README.md

+```bash
+echo "  storageClassName: managed-premium-retain" >> ../helm/ditto-mongodb-pvc.yaml
+kubectl apply -f ../helm/ditto-mongodb-pvc.yaml --namespace $k8s_namespace
+helm upgrade ditto ../helm/eclipse-ditto/ --namespace $k8s_namespace --set service.type=LoadBalancer,mongodb.persistence.enabled=true,mongodb.persistence.existingClaim=ditto-pvc --wait --install


ditto-mongodb-pvc has now to be used here also for the existingClaim ;-)

…n@microsoft.com>

ghandim · 2019-04-01T15:46:42Z

@kaizimmerm One last thing....
Are there any concerns to update the ditto tag to the current milestone 0.9.0-M1?

kaizimmerm · 2019-04-02T08:18:19Z

@ghandim sure, will do that

ghandim · 2019-04-02T08:28:40Z

@kaizimmerm Last but not least I would reduce the values in Charts.yaml to

apiVersion: v1
name: eclipse-ditto
version: 0.9.0-M1
description: A basic helm chart for Eclipse Ditto and K8s

What do you think?

…soft.com>

ghandim · 2019-04-02T09:56:47Z

@kaizimmerm LGTM 👍 @thjaeckle Nothing more to add from my point of view at the moment.

thjaeckle · 2019-04-02T10:37:34Z

Awesome, thank you both for the effort 👍

Enable support for MongoDb with persistenceSigned-off-by: Kai Zimmerm…

c7d796d

…ann <kai.zimmermann@microsoft.com>

ghandim reviewed Mar 28, 2019

View reviewed changes

Add helm dependecy update.

daa0010

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim reviewed Mar 29, 2019

View reviewed changes

Merged master

54ffe89

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

Custom PVC integrated

c818d43

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim reviewed Apr 1, 2019

View reviewed changes

Fix helm update command

bf539b5

Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>

ghandim reviewed Apr 1, 2019

View reviewed changes

More meaningful PVC name.Signed-off-by: Kai Zimmermann <kai.zimmerman…

83fa39d

…n@microsoft.com>

kaizimmerm force-pushed the k8s-mongodb-persitence branch from 704ec1d to 83fa39d Compare April 1, 2019 15:10

Update to 0.9.0-M1Signed-off-by: Kai Zimmermann <kai.zimmermann@micro…

3f2257b

…soft.com>

kaizimmerm force-pushed the k8s-mongodb-persitence branch from af8bd92 to 3f2257b Compare April 2, 2019 08:46

thjaeckle merged commit 790beeb into eclipse-ditto:master Apr 2, 2019

kaizimmerm deleted the k8s-mongodb-persitence branch April 5, 2019 06:22

thjaeckle added this to the 0.9.0-M2 milestone Apr 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable support for MongoDB persistence in K8s #364

Enable support for MongoDB persistence in K8s #364

kaizimmerm commented Mar 27, 2019

ghandim commented Mar 28, 2019

kaizimmerm commented Mar 28, 2019

ghandim commented Mar 28, 2019

ghandim Mar 28, 2019 •

edited

ghandim Mar 29, 2019

ghandim Mar 29, 2019 •

edited

ghandim commented Mar 29, 2019 •

edited

thjaeckle commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

ghandim commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

ghandim Apr 1, 2019

kaizimmerm Apr 1, 2019

ghandim Apr 1, 2019

kaizimmerm Apr 1, 2019

ghandim Apr 1, 2019

kaizimmerm Apr 1, 2019

ghandim commented Apr 1, 2019

kaizimmerm commented Apr 2, 2019

ghandim commented Apr 2, 2019

ghandim commented Apr 2, 2019

thjaeckle commented Apr 2, 2019

Enable support for MongoDB persistence in K8s #364

Enable support for MongoDB persistence in K8s #364

Conversation

kaizimmerm commented Mar 27, 2019

ghandim commented Mar 28, 2019

kaizimmerm commented Mar 28, 2019

ghandim commented Mar 28, 2019

ghandim Mar 28, 2019 • edited

Choose a reason for hiding this comment

ghandim Mar 29, 2019

Choose a reason for hiding this comment

ghandim Mar 29, 2019 • edited

Choose a reason for hiding this comment

ghandim commented Mar 29, 2019 • edited

thjaeckle commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

ghandim commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

kaizimmerm commented Apr 1, 2019

ghandim Apr 1, 2019

Choose a reason for hiding this comment

kaizimmerm Apr 1, 2019

Choose a reason for hiding this comment

ghandim Apr 1, 2019

Choose a reason for hiding this comment

kaizimmerm Apr 1, 2019

Choose a reason for hiding this comment

ghandim Apr 1, 2019

Choose a reason for hiding this comment

kaizimmerm Apr 1, 2019

Choose a reason for hiding this comment

ghandim commented Apr 1, 2019

kaizimmerm commented Apr 2, 2019

ghandim commented Apr 2, 2019

ghandim commented Apr 2, 2019

thjaeckle commented Apr 2, 2019

ghandim Mar 28, 2019 •

edited

ghandim Mar 29, 2019 •

edited

ghandim commented Mar 29, 2019 •

edited