Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/response required for events and responses #850

Conversation

Yannic92
Copy link
Contributor

Responses to events and responses are not supported in ditto. Therefore it makes sense to enforce that a published response or event does always have the header value of response-required set to false.

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
validation purposes

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
@thjaeckle thjaeckle added this to the 1.4.0 milestone Oct 22, 2020
@yufei-cai yufei-cai self-requested a review October 22, 2020 15:53
Copy link
Contributor

@yufei-cai yufei-cai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yufei-cai yufei-cai merged commit 8fc8f84 into eclipse-ditto:master Oct 22, 2020
@yufei-cai yufei-cai deleted the bugfix/response-required-for-events-and-responses branch October 22, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants