Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter in org.eclipse.collections.impl.factory.Sets.adapt() #1380

Closed
donraab opened this issue Aug 24, 2022 · 4 comments
Closed

Rename parameter in org.eclipse.collections.impl.factory.Sets.adapt() #1380

donraab opened this issue Aug 24, 2022 · 4 comments
Assignees
@ibrahim-5
Labels
good first issue help wanted minor-version tech-debt

Comments

@donraab
Copy link
Contributor

donraab commented Aug 24, 2022

The parameter is currently named list, and should be named set.
@ibrahim-5
Copy link
Contributor

ibrahim-5 commented Aug 24, 2022 •
edited
Loading

Hi @donraab 👋🏿 . I've opened a pull request here : #1382

@donraab
Copy link
Contributor Author

donraab commented Aug 24, 2022

Hi @ibrahim-5, thanks for volunteering and contributing! I've assigned the task (so no one else goes to pick it up) and approved the builds to run. Will review the PR tonight. Thanks!

@ibrahim-5
Copy link
Contributor

Thanks! I'll be waiting 😄

@donraab
Copy link
Contributor Author

donraab commented Aug 25, 2022

Congrats on your first EC PR getting merged @ibrahim-5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibrahim-5 ibrahim-5

Labels
good first issue help wanted minor-version tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donraab @ibrahim-5