Skip to content

Commit

Permalink
create issue for malformed comparator
Browse files Browse the repository at this point in the history
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
  • Loading branch information
Eskibear authored and fbricon committed Nov 7, 2019
1 parent bf29bfc commit a1369a3
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -145,7 +145,7 @@ public List<Either<Command, CodeAction>> getCodeActionCommands(CodeActionParams
}
}

// TODO (Yan): below comparator seldomly compares relavance, it returns early if code action kind is different.
// TODO (Yan): See https://github.com/eclipse/eclipse.jdt.ls/issues/1250
proposals.sort(new ChangeCorrectionProposalComparator());

// TODO (Yan): below block post-filters the proposals by CodeActionKind, can be removed in future if all above processors are doing right things.
Expand Down

0 comments on commit a1369a3

Please sign in to comment.